FreeCalypso > hg > fc-magnetite

view src/ui3/mfw/mfw_cb.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e8ddbb0837ed
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: GSM-MFW (?)                  $Workfile:: mfw_cb.h       $|
| $Author:: Es                          $Revision::  1              $|
| CREATED: 14.10.98                     $Modtime:: 27.10.98 17:32   $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

	PURPOSE :  Types definitions for MMI framework call backs distribution

	$History:: mfw_cm.h                                              $

        May 10, 2006    REF: DRT OMAPS00075829  xdeepadh
        Description: Submission of ACI and SAP changes for Imaging ERs 
        Solution: Using the mechanism where MFW can receive primitives without
        ACI to know about it.

	x0018858 24 Mar, 2005 MMI-FIX-11321
	Issue Description :- If the inbox is full and a new message is receivd, no indication is received.
	Fix: Added support for handling indication when message box is full and
	there is a pending message.


    .
*/

#ifndef DEF_MFW_CB_HEADER
#define DEF_MFW_CB_HEADER

// May 10, 2006    REF: DRT OMAPS00075829  xdeepadh
#if defined(FF_MMI_FILEMANAGER)||defined(FF_MMI_CAMERA_APP)

/*Defining the premitive*/
#define MSL_MMI_IND      0x110   /*Specifying hex value */

typedef struct
{
  U32                       handle;                   /*<  0:  4> Basic Element                                      */
  U32                       appData;                  /*<  4:  4> Basic Element                                      */
  U32                       message;                  /*<  8:  4> Basic Element                                      */
  U32                       ucp;                      /*< 12:  4> Basic Element                                      */
} T_MSL_MMI_IND;



#endif //defined(FF_MMI_FILEMANAGER)||defined(FF_MMI_CAMERA_APP)
/*
 * not yet defined in aci_cmh.h
 */
#define CME_ERR_SimPin2Req  35
#define CME_ERR_SimPuk2Req  36
//	x0018858 24 Mar, 2005 MMI-FIX-11321
extern UBYTE sms_check_message_pending(void);
// May 10, 2006    REF: DRT OMAPS00075829  xdeepadh
#if defined(FF_MMI_FILEMANAGER)||defined(FF_MMI_CAMERA_APP)
GLOBAL BOOL mslPrimHandler (USHORT opc, void * data) ;
GLOBAL  void Mslil_msl_mmi_ind ( T_MSL_MMI_IND *msl_mmi_ind); /*a0393213 compiler warning removal - removed const*/
/*a0393213 cphs rel4*/
#ifdef FF_CPHS_REL4
GLOBAL void rAT_PercentCFIS ( T_ACI_CFIS_CFU *cfis );
#endif
#endif //#if defined(FF_MMI_FILEMANAGER)||defined(FF_MMI_CAMERA_APP)
#endif