FreeCalypso > hg > fc-magnetite

view src/ui3/mfw/mfw_phbi.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e8ddbb0837ed
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT:  GSM-MFW (8417)              $Workfile:: mfw_phbi.h       $|
| $Author:: Vo                          $Revision::  1              $|
| CREATED:  7.1.99                      $Modtime:: 12.01.00 11:26   $|
| STATE  :  code                                                     |
+--------------------------------------------------------------------+

	PURPOSE :  Internal types defination for phonebook management
    . 
*/ 

#ifndef DEF_MFW_PHBI
#define DEF_MFW_PHBI

/*
 *  PHB Control Block
 */
typedef struct
{
    T_MFW_EVENT     emask;          /* events of interest */
    T_MFW_EVENT     event;          /* current event */
    T_MFW_CB        handler;
    T_MFW_PHB_PARA  para;
} T_MFW_PHB;

EXTERN BOOL     phb_sign_exec            (T_MFW_HDR * hdr,
                                          T_MFW_EVENT event, 
                                          T_MFW_PHB_PARA *para);
EXTERN void     phb_ok_clck              (void);
EXTERN void     phb_error_clck           (void);
EXTERN T_MFW_PHB_TON phb_cvtTon          (T_ACI_TOA_TON ton);
EXTERN T_MFW_PHB_NPI phb_cvtNpi          (T_ACI_TOA_NPI npi);/*a0393213 warnings removal-return type changed from T_MFW_PHB_TON*/
EXTERN T_ACI_TOA_TON phb_ncvtTon         (T_MFW_PHB_TON ton);
EXTERN T_ACI_TOA_NPI phb_ncvtNpi         (T_MFW_PHB_NPI npi);/*a0393213 warnings removal-argument type changed from T_MFW_PHB_TON*/
EXTERN void     phb_read_upn_eeprom      (void);

#endif