FreeCalypso > hg > fc-magnetite

view src/ui3/mfw/mfw_tim.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e8ddbb0837ed
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: MMI-Framework (8417)         $Workfile:: mfw_tim.h       $|
| $Author:: Es  $ CONDAT GmbH           $Revision:: 8               $|
| CREATED: 21.09.98                     $Modtime:: 2.03.00 11:50    $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

   MODULE  : MFW_TIM

   PURPOSE : Timer types & constants

   EXPORT  :

   TO DO   :

   $History:: mfw_tim.h                                             $
 * 
 * *****************  Version 8  *****************
 * User: Es           Date: 3.03.00    Time: 12:10
 * Updated in $/GSM/Condat/MS/SRC/MFW
 * timStart(), timSignal() etc.: safer handling of simultaneous
 * timeouts; additional chain in timer control block.
 *
 * *****************  Version 7  *****************
 * User: Nm           Date: 18.02.00   Time: 12:34
 * Updated in $/GSM/Condat/MS/SRC/MFW
 * change the name timSetup to
 * timSetTime
 *
 * *****************  Version 6  *****************
 * User: Nm           Date: 18.02.00   Time: 12:21
 * Updated in $/GSM/Condat/MS/SRC/MFW
 * add timSetup()
 *
 * *****************  Version 5  *****************
 * User: Es           Date: 14.06.99   Time: 12:14
 * Updated in $/GSM/DEV/MS/SRC/MFW
 *
 * *****************  Version 4  *****************
 * User: Es           Date: 17.02.99   Time: 19:11
 * Updated in $/GSM/DEV/MS/SRC/MFW
 *
 * *****************  Version 3  *****************
 * User: Es           Date: 14.01.99   Time: 17:19
 * Updated in $/GSM/DEV/MS/SRC/MFW
 *
 * *****************  Version 2  *****************
 * User: Es           Date: 23.12.98   Time: 16:19
 * Updated in $/GSM/DEV/MS/SRC/MFW
*/

#ifndef _DEF_MFW_TIM_H_
#define _DEF_MFW_TIM_H_

typedef struct MfwTimTag                /* TIMER CONTROL BLOCK      */
{
    S32 time;                           /* timeout time             */
    S32 left;                           /* time left before timeout */
    MfwCb handler;                      /* event handler            */
    struct MfwTimTag *next;             /* next in active chain     */
    struct MfwTimTag *next2;            /* next in timeout chain    */
    // PATCH LE 06.06.00
    // add pointer to MFW header element
    MfwHdr * mfwHeader;                /* Associated header.  SPR#1597 - SH - Change mfw_header to mfwHeader */
    // END PATCH LE 06.06.00
} MfwTim;

                                        /* PROTOTYPES               */
MfwRes timInit (void);
MfwRes timExit (void);
MfwHnd timCreate (MfwHnd w, S32 t, MfwCb f);
MfwRes timDelete (MfwHnd h);
MfwRes timStart (MfwHnd tim);
MfwRes timStop (MfwHnd tim);
MfwRes timSetTime (MfwHnd tim, S32 t);
S32 timTime (MfwHnd h);
void timSignal (void);

/* Added to remove warning */
EXTERN UBYTE dspl_Enable (UBYTE   in_Enable);

#endif