FreeCalypso > hg > fc-magnetite
view src/g23m-gprs/upm/upm_aci_output_handler.c @ 600:8f50b202e81f
board preprocessor conditionals: prep for more FC hw in the future
This change eliminates the CONFIG_TARGET_FCDEV3B preprocessor symbol and
all preprocessor conditionals throughout the code base that tested for it,
replacing them with CONFIG_TARGET_FCFAM or CONFIG_TARGET_FCMODEM. These
new symbols are specified as follows:
CONFIG_TARGET_FCFAM is intended to cover all hardware designs created by
Mother Mychaela under the FreeCalypso trademark. This family will include
modem products (repackagings of the FCDEV3B, possibly with RFFE or even
RF transceiver changes), and also my desired FreeCalypso handset product.
CONFIG_TARGET_FCMODEM is intended to cover all FreeCalypso modem products
(which will be firmware-compatible with the FCDEV3B if they use TI Rita
transceiver, or will require a different fw build if we switch to one of
Silabs Aero transceivers), but not the handset product. Right now this
CONFIG_TARGET_FCMODEM preprocessor symbol is used to conditionalize
everything dealing with MCSI.
At the present moment the future of FC hardware evolution is still unknown:
it is not known whether we will ever have any beyond-FCDEV3B hardware at all
(contingent on uncertain funding), and if we do produce further FC hardware
designs, it is not known whether they will retain the same FIC modem core
(triband), if we are going to have a quadband design that still retains the
classic Rita transceiver, or if we are going to switch to Silabs Aero II
or some other transceiver. If we produce a quadband modem that still uses
Rita, it will run exactly the same fw as the FCDEV3B thanks to the way we
define TSPACT signals for the RF_FAM=12 && CONFIG_TARGET_FCFAM combination,
and the current fcdev3b build target will be renamed to fcmodem. OTOH, if
that putative quadband modem will be Aero-based, then it will require a
different fw build target, the fcdev3b target will stay as it is, and the
two targets will both define CONFIG_TARGET_FCFAM and CONFIG_TARGET_FCMODEM,
but will have different RF_FAM numbers. But no matter which way we are
going to evolve, it is not right to have conditionals on CONFIG_TARGET_FCDEV3B
in places like ACI, and the present change clears the way for future
evolution.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 01 Apr 2019 01:05:24 +0000 |
parents | 2cf312e56ee7 |
children |
line wrap: on
line source
/*---------------------------------------------------------------------------- | Project : 3G PS | Module : UPM +----------------------------------------------------------------------------- | Copyright 2003 Texas Instruments. | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments . | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments. +----------------------------------------------------------------------------- | Purpose: Output functions for primitives from UPM to the ACI entity. | For design details, see: | 8010.939 UPM Detailed Specification +---------------------------------------------------------------------------*/ /*==== DECLARATION CONTROL =================================================*/ /*==== INCLUDES ============================================================*/ #include "upm.h" #include "upm_aci_output_handler.h" /*==== CONSTS ===============================================================*/ /*==== TYPES ================================================================*/ /*==== LOCALS ===============================================================*/ /*==== PUBLIC FUNCTIONS =====================================================*/ /* +------------------------------------------------------------------------------ | Function : send_upm_count_cnf +------------------------------------------------------------------------------ | Description : Allocate, pack and send UPM_COUNT_CNF primitive. | | Parameters : nsapi - NSAPI | ul_bytecount - number of uplink octets transferred | ul_pktcount - number of uplink packets transferred | dl_bytecount - number of downlink octets transferred | dl_pktcount - number of downlink packets transferred +------------------------------------------------------------------------------ */ void send_upm_count_cnf(U8 nsapi, U32 ul_bytecount, U32 dl_bytecount, U32 ul_pktcount, U32 dl_pktcount) { (void)TRACE_FUNCTION("send_upm_count_cnf"); { PALLOC(prim, UPM_COUNT_CNF); TRACE_ASSERT(prim != NULL); /*lint -e613 (Possible use of null pointer 'prim' in left argument to operator '->') */ prim->nsapi = nsapi; prim->octets_uplink = ul_bytecount; prim->octets_downlink = dl_bytecount; prim->packets_uplink = ul_pktcount; prim->packets_downlink = dl_pktcount; /*lint +e613 (Possible use of null pointer 'prim' in left argument to operator '->') */ (void)PSEND(hCommACI, prim); } } /* +------------------------------------------------------------------------------ | Function : send_upm_dti_cnf +------------------------------------------------------------------------------ | Description : Allocate, pack and send UPM_DTI_CNF primitive. | | Parameters : dti_linkid - DTI link ID | dti_conn - connection type +------------------------------------------------------------------------------ */ void send_upm_dti_cnf(U32 dti_linkid, U8 dti_conn) { (void)TRACE_FUNCTION("send_upm_dti_cnf"); { PALLOC(prim, UPM_DTI_CNF); TRACE_ASSERT(prim != NULL); /*lint -e613 (Possible use of null pointer 'prim' in left argument to operator '->') */ prim->dti_linkid = dti_linkid; prim->dti_conn = dti_conn; /*lint +e613 (Possible use of null pointer 'prim' in left argument to operator '->') */ (void)PSEND(hCommACI, prim); } } /*==== END OF FILE ==========================================================*/