changeset 225:b16d79c550a2

aci2: AT@SC bogon fully expunged
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 24 Oct 2016 05:50:25 +0000
parents 08543d6806b0
children 67fe1b3f4bd7
files src/aci2/aci/ati_cmd.c src/aci2/aci/ati_omcompat.c
diffstat 2 files changed, 5 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/src/aci2/aci/ati_cmd.c	Mon Oct 24 00:07:49 2016 +0000
+++ b/src/aci2/aci/ati_cmd.c	Mon Oct 24 05:50:25 2016 +0000
@@ -664,14 +664,11 @@
 
 /* FreeCalypso replicating Openmoko's additions */
 EXTERN T_ATI_RSLT atAtST (CHAR *cl, UBYTE srcId);
-EXTERN T_ATI_RSLT tesatAtST (CHAR *cl, UBYTE srcId);
 EXTERN T_ATI_RSLT queatAtST (CHAR *cl, UBYTE srcId);
 EXTERN T_ATI_RSLT atAtAUL (CHAR *cl, UBYTE srcId);
-EXTERN T_ATI_RSLT tesatAtAUL (CHAR *cl, UBYTE srcId);
 EXTERN T_ATI_RSLT queatAtAUL (CHAR *cl, UBYTE srcId);
 EXTERN T_ATI_RSLT atAtPOFF (CHAR *cl, UBYTE srcId);
 EXTERN T_ATI_RSLT atAtRST (CHAR *cl, UBYTE srcId);
-EXTERN T_ATI_RSLT atAtSC (CHAR *cl, UBYTE srcId);
 EXTERN T_ATI_RSLT atAtBAND (CHAR *cl, UBYTE srcId);
 
 LOCAL const ATCommand_bas cmds_bas[] =
@@ -1058,7 +1055,6 @@
     {"@AUL",       AT_CMD_P_AUL,   atAtAUL,       test_gen,       queatAtAUL,    "%s: (0)"},
     {"@POFF",       AT_CMD_P_POFF,   atAtPOFF,       0,       0,    0},
     {"@RST",       AT_CMD_P_RST,   atAtRST,       0,       0,    0},
-    {"@SC",       AT_CMD_P_SC,     atAtSC,       0,       0,    0},
     {"@BAND",     AT_CMD_P_BAND,   atAtBAND,     0,       0,    0},
     {NULL,0,0,0,0,0}
 };
--- a/src/aci2/aci/ati_omcompat.c	Mon Oct 24 00:07:49 2016 +0000
+++ b/src/aci2/aci/ati_omcompat.c	Mon Oct 24 05:50:25 2016 +0000
@@ -205,23 +205,14 @@
 /*
  * Openmoko's firmware contains an undocumented AT@SC command that
  * sets/changes the IMEI of the modem.  However, it takes the IMEI
- * input in an obfuscated form, and the implementation code is
- * rather ugly - hence I don't feel like reimplementing it here.
+ * input in an obfuscated form, and the logic is broken - hence
+ * we are NOT reimplementing this bogon in FreeCalypso.
  *
- * If you feel like changing your modem's IMEI, you can do it quite
- * easily with FreeCalypso tools: use fc-loadtool to read the FFS
- * sectors out of flash, then mpffs-edit to change the /pcm/IMEI file
- * in the FFS image, then fc-loadtool again to program the modified
- * FFS image back into flash.
+ * If you feel like changing your modem's IMEI, you can do it
+ * through the RVTMUX interface with our fc-fsio utility's
+ * set-imeisv command.
  */
 
-GLOBAL T_ATI_RSLT atAtSC (char *cl, UBYTE srcId)
-{		
-	TRACE_FUNCTION("atAtSC");			
-
-	return (ATI_FAIL);	
-}
-
 /*
  * PURPOSE : @BAND command (Get RF band)
  */