annotate components/misc_ir @ 220:0ed36de51973

ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents 58b05205d579
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
28
b5a5e3ea94ed components: GPF library recipes preened
Mychaela Falconia <falcon@freecalypso.org>
parents: 26
diff changeset
1 # Building misc_ir.lib using the GPF source bits we got with TCS211
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-mw -x -pw2 -o -me -mt -g -mn"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS="-D_TARGET_ -D_NUCLEUS_ -DRUN_INT_RAM"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 # Includes
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
23
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
11 CPPFLAGS="$CPPFLAGS -I$SRC/gpf/misc"
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
12 CPPFLAGS="$CPPFLAGS -I$SRC/gpf/inc/nuc"
26
598958aec071 components: switch to new Nucleus
Mychaela Falconia <falcon@freecalypso.org>
parents: 23
diff changeset
13 CPPFLAGS="$CPPFLAGS -I$SRC/nucleus"
23
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
14 CPPFLAGS="$CPPFLAGS -I$SRC/gpf/inc"
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 # Source modules
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
23
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
18 SRCDIR=$SRC/gpf/misc
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 cfile_plain $SRCDIR/printtofile.c
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 cfile_plain $SRCDIR/tok.c
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 cfile_plain $SRCDIR/tools.c
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 cfile_plain $SRCDIR/misc_version.c