annotate components/ppp_ir @ 220:0ed36de51973

ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents e58a5bb12de4
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 # Building ppp_ir.lib from the TCS3.2 source
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 CFLAGS="-me -mt -o -pw2 -x -mw"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 # Defines
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 CPPFLAGS=-DCCDTABLES_EXTERN
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 CPPFLAGS="$CPPFLAGS -DOPTION_MULTITHREAD"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 CPPFLAGS="$CPPFLAGS -DNEW_FRAME"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 CPPFLAGS="$CPPFLAGS -DNEW_ENTITY"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 CPPFLAGS="$CPPFLAGS -D_TARGET_"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 CPPFLAGS="$CPPFLAGS -DSHARED_VSI"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 CPPFLAGS="$CPPFLAGS -DALR"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 CPPFLAGS="$CPPFLAGS -DFF_HOMEZONE"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 CPPFLAGS="$CPPFLAGS -DFF_MMI_SAT_ICON"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 CPPFLAGS="$CPPFLAGS -DFF_MMI_SMS_DYNAMIC"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 CPPFLAGS="$CPPFLAGS -DFF_CPHS"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 CPPFLAGS="$CPPFLAGS -D_TMS470"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 CPPFLAGS="$CPPFLAGS -DUART"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 CPPFLAGS="$CPPFLAGS -DFF_ATI"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 CPPFLAGS="$CPPFLAGS -DNWARN"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 CPPFLAGS="$CPPFLAGS -DFF_EM_MODE"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 CPPFLAGS="$CPPFLAGS -DPHONEBOOK_EXTENSION"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 if [ "$GPRS" = 1 ]
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 then
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 CPPFLAGS="$CPPFLAGS -DGPRS"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 fi
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 CPPFLAGS="$CPPFLAGS -DAT_INTERPRETER"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 CPPFLAGS="$CPPFLAGS -DUSE_L1FD_FUNC_INTERFACE"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 if [ "$SRVC" != 0 ]
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 then
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 CPPFLAGS="$CPPFLAGS -DFAX_AND_DATA"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 if [ "$SRVC" = 1 ]
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
37 then
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 CPPFLAGS="$CPPFLAGS -DFF_FAX"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 fi
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 CPPFLAGS="$CPPFLAGS -DUSE_L2FD_FUNC_INTERFACE"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
41 fi
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
42
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 CPPFLAGS="$CPPFLAGS -DSRVC=$SRVC"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 CPPFLAGS="$CPPFLAGS -DDTI2"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 CPPFLAGS="$CPPFLAGS -DDTILIB"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
46 CPPFLAGS="$CPPFLAGS -DPPP_INT_RAM"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 CPPFLAGS="$CPPFLAGS -DCHIPSET=$CHIPSET"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 CPPFLAGS="$CPPFLAGS -DBOARD=41"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
49
38
e58a5bb12de4 experimental support for GPF memory supervision
Mychaela Falconia <falcon@freecalypso.org>
parents: 23
diff changeset
50 if [ "$MEMSUPER" != 0 ]
e58a5bb12de4 experimental support for GPF memory supervision
Mychaela Falconia <falcon@freecalypso.org>
parents: 23
diff changeset
51 then
e58a5bb12de4 experimental support for GPF memory supervision
Mychaela Falconia <falcon@freecalypso.org>
parents: 23
diff changeset
52 CPPFLAGS="$CPPFLAGS -DMEMORY_SUPERVISION"
e58a5bb12de4 experimental support for GPF memory supervision
Mychaela Falconia <falcon@freecalypso.org>
parents: 23
diff changeset
53 fi
e58a5bb12de4 experimental support for GPF memory supervision
Mychaela Falconia <falcon@freecalypso.org>
parents: 23
diff changeset
54
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 # Includes
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
57 SRCDIR=$SRC/g23m-fad/ppp
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
58
23
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
59 CPPFLAGS="$CPPFLAGS -I$SRC/condat/com/inc"
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
60 CPPFLAGS="$CPPFLAGS -I$SRC/gpf/inc"
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
61 CPPFLAGS="$CPPFLAGS -I$SRC/condat/com/include"
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
62 CPPFLAGS="$CPPFLAGS -I../../cdg-hybrid/cdginc"
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
63 CPPFLAGS="$CPPFLAGS -I$SRCDIR"
23
fdc83c1ab3ff components: first automated conversion pass
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
64 CPPFLAGS="$CPPFLAGS -I../../cdg-hybrid/sap-inline"
22
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
65 CPPFLAGS="$CPPFLAGS -I.."
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
66 CPPFLAGS="$CPPFLAGS -I../config"
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
67
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
68 # Source modules
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
69
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
70 cfile_str2ind $SRCDIR/ppp_frxf.c
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
71 cfile_str2ind $SRCDIR/ppp_ftxf.c
7ded024bf471 components: pruned import from Magnetite
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
72 cfile_str2ind $SRCDIR/ppp_tbls.c