FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_gsmcom.val @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 35f7a1dc9f7d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_gsmcom.val | | SOURCE : "sap\gsmcom.pdf" | | LastModified : "2002-10-04" | | IdAndVersion : "8443.100.02.008" | | SrcFileTime : "Thu Nov 29 09:43:26 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_GSMCOM_VAL #define P_GSMCOM_VAL #define CDG_ENTER__P_GSMCOM_VAL #define CDG_ENTER__FILENAME _P_GSMCOM_VAL #define CDG_ENTER__P_GSMCOM_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_GSMCOM_VAL__LAST_MODIFIED _2002_10_04 #define CDG_ENTER__P_GSMCOM_VAL__ID_AND_VERSION _8443_100_02_008 #define CDG_ENTER__P_GSMCOM_VAL__SRC_FILE_TIME _Thu_Nov_29_09_43_26_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_GSMCOM_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_gsmcom_dummy */ /* * user defined constants */ #define SIM_ORIGINATING_ENTITY (0x0) #define ACI_ORIGINATING_ENTITY (0x1) #define RLP_ORIGINATING_ENTITY (0x2) #define RR_ORIGINATING_ENTITY (0x3) #define MM_ORIGINATING_ENTITY (0x4) #define CC_ORIGINATING_ENTITY (0x5) #define SS_ORIGINATING_ENTITY (0x6) #define SMSCP_ORIGINATING_ENTITY (0x7) #define SMSRP_ORIGINATING_ENTITY (0x8) #define SMSTP_ORIGINATING_ENTITY (0x9) #define GMM_ORIGINATING_ENTITY (0xa) #define SM_ORIGINATING_ENTITY (0xb) #define FAD_ORIGINATING_ENTITY (0xc) #define T30_ORIGINATING_ENTITY (0xd) #define GRR_ORIGINATING_ENTITY (0xe) #define PPP_ORIGINATING_ENTITY (0xf) #define LLC_ORIGINATING_ENTITY (0x10) #define SNDCP_ORIGINATING_ENTITY (0x11) #define PKTIO_ORIGINATING_ENTITY (0x12) #define PSI_ORIGINATING_ENTITY (0x13) #include "CDG_LEAVE.h" #endif