FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_mnss.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 35f7a1dc9f7d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_mnss.h | | SOURCE : "sap\mnss.pdf" | | LastModified : "2002-08-01" | | IdAndVersion : "6147.102.97.104" | | SrcFileTime : "Thu Nov 29 09:48:44 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_MNSS_H #define P_MNSS_H #define CDG_ENTER__P_MNSS_H #define CDG_ENTER__FILENAME _P_MNSS_H #define CDG_ENTER__P_MNSS_H__FILE_TYPE CDGINC #define CDG_ENTER__P_MNSS_H__LAST_MODIFIED _2002_08_01 #define CDG_ENTER__P_MNSS_H__ID_AND_VERSION _6147_102_97_104 #define CDG_ENTER__P_MNSS_H__SRC_FILE_TIME _Thu_Nov_29_09_48_44_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_MNSS_H #undef CDG_ENTER__FILENAME #include "p_mnss.val" #ifndef __T_fac_inf__ #define __T_fac_inf__ /* * facility information * CCDGEN:WriteStruct_Count==2009 */ typedef struct { U16 l_fac; /*< 0: 2> facility length */ U16 o_fac; /*< 2: 2> facility offset */ U8 fac[FACILITY_LEN]; /*< 4:251> facility content */ U8 _align0; /*<255: 1> alignment */ } T_fac_inf; #endif #ifndef __T_ss_ver__ #define __T_ss_ver__ /* * ss version * CCDGEN:WriteStruct_Count==2010 */ typedef struct { U8 len; /*< 0: 1> length of ss version */ U8 ver[VERSION_LEN]; /*< 1: 8> ss version content */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ } T_ss_ver; #endif /* * End of substructure section, begin of primitive definition section */ #ifndef __T_MNSS_BEGIN_REQ__ #define __T_MNSS_BEGIN_REQ__ /* * * CCDGEN:WriteStruct_Count==2011 */ typedef struct { U8 ti; /*< 0: 1> Transaction Identifier */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ T_fac_inf fac_inf; /*< 4:256> facility information */ T_ss_ver ss_ver; /*<260: 12> ss version */ } T_MNSS_BEGIN_REQ; #endif #ifndef __T_MNSS_FACILITY_REQ__ #define __T_MNSS_FACILITY_REQ__ /* * * CCDGEN:WriteStruct_Count==2012 */ typedef struct { U8 ti; /*< 0: 1> Transaction Identifier */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ T_fac_inf fac_inf; /*< 4:256> facility information */ T_ss_ver ss_ver; /*<260: 12> ss version */ } T_MNSS_FACILITY_REQ; #endif #ifndef __T_MNSS_END_REQ__ #define __T_MNSS_END_REQ__ /* * * CCDGEN:WriteStruct_Count==2013 */ typedef struct { U8 ti; /*< 0: 1> Transaction Identifier */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ T_fac_inf fac_inf; /*< 4:256> facility information */ } T_MNSS_END_REQ; #endif #ifndef __T_MNSS_BEGIN_IND__ #define __T_MNSS_BEGIN_IND__ /* * * CCDGEN:WriteStruct_Count==2014 */ typedef struct { U8 ti; /*< 0: 1> Transaction Identifier */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ T_fac_inf fac_inf; /*< 4:256> facility information */ } T_MNSS_BEGIN_IND; #endif #ifndef __T_MNSS_FACILITY_IND__ #define __T_MNSS_FACILITY_IND__ /* * * CCDGEN:WriteStruct_Count==2015 */ typedef struct { U8 ti; /*< 0: 1> Transaction Identifier */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ T_fac_inf fac_inf; /*< 4:256> facility information */ } T_MNSS_FACILITY_IND; #endif #ifndef __T_MNSS_END_IND__ #define __T_MNSS_END_IND__ /* * * CCDGEN:WriteStruct_Count==2016 */ typedef struct { U8 ti; /*< 0: 1> Transaction Identifier */ U8 _align0; /*< 1: 1> alignment */ U16 cause; /*< 2: 2> cause */ T_fac_inf fac_inf; /*< 4:256> facility information */ } T_MNSS_END_IND; #endif #include "CDG_LEAVE.h" #endif