FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_udp.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 35f7a1dc9f7d |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_udp.h | | SOURCE : "sap\udp.pdf" | | LastModified : "2003-08-26" | | IdAndVersion : "8444.100.00.006" | | SrcFileTime : "Thu Nov 29 09:56:22 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_UDP_H #define P_UDP_H #define CDG_ENTER__P_UDP_H #define CDG_ENTER__FILENAME _P_UDP_H #define CDG_ENTER__P_UDP_H__FILE_TYPE CDGINC #define CDG_ENTER__P_UDP_H__LAST_MODIFIED _2003_08_26 #define CDG_ENTER__P_UDP_H__ID_AND_VERSION _8444_100_00_006 #define CDG_ENTER__P_UDP_H__SRC_FILE_TIME _Thu_Nov_29_09_56_22_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_UDP_H #undef CDG_ENTER__FILENAME #include "p_udp.val" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_UDP_BIND_REQ__ #define __T_UDP_BIND_REQ__ /* * * CCDGEN:WriteStruct_Count==3144 */ typedef struct { U16 port; /*< 0: 2> destination port */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_UDP_BIND_REQ; #endif #ifndef __T_UDP_BIND_CNF__ #define __T_UDP_BIND_CNF__ /* * * CCDGEN:WriteStruct_Count==3145 */ typedef struct { U16 port; /*< 0: 2> destination port */ U8 err; /*< 2: 1> error code */ U8 _align0; /*< 3: 1> alignment */ } T_UDP_BIND_CNF; #endif #ifndef __T_UDP_CLOSEPORT_REQ__ #define __T_UDP_CLOSEPORT_REQ__ /* * * CCDGEN:WriteStruct_Count==3146 */ typedef struct { U16 port; /*< 0: 2> destination port */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_UDP_CLOSEPORT_REQ; #endif #ifndef __T_UDP_CLOSEPORT_CNF__ #define __T_UDP_CLOSEPORT_CNF__ /* * * CCDGEN:WriteStruct_Count==3147 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_CLOSEPORT_CNF; #endif #ifndef __T_UDP_ERROR_IND__ #define __T_UDP_ERROR_IND__ /* * * CCDGEN:WriteStruct_Count==3148 */ typedef struct { U16 dst_port; /*< 0: 2> destination port */ U16 src_port; /*< 2: 2> source port */ U8 err_msg; /*< 4: 1> error message */ U8 _align0; /*< 5: 1> alignment */ U8 _align1; /*< 6: 1> alignment */ U8 _align2; /*< 7: 1> alignment */ U32 src_addr; /*< 8: 4> source address */ U32 dst_addr; /*< 12: 4> destination address */ } T_UDP_ERROR_IND; #endif #ifndef __T_UDP_ERROR_RES__ #define __T_UDP_ERROR_RES__ /* * * CCDGEN:WriteStruct_Count==3149 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_ERROR_RES; #endif #ifndef __T_UDP_SHUTDOWN_IND__ #define __T_UDP_SHUTDOWN_IND__ /* * * CCDGEN:WriteStruct_Count==3150 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_SHUTDOWN_IND; #endif #ifndef __T_UDP_SHUTDOWN_RES__ #define __T_UDP_SHUTDOWN_RES__ /* * * CCDGEN:WriteStruct_Count==3151 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_UDP_SHUTDOWN_RES; #endif #include "CDG_LEAVE.h" #endif