FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/sap/mnlc.pdf @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 35f7a1dc9f7d |
children |
line wrap: on
line source
;******************************************************************************** ;*** File : mnlc.pdf ;*** Creation : Wed Mar 11 09:58:25 CST 2009 ;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1 ;*** Copyright : (c) Texas Instruments AG, Berlin Germany 2002 ;******************************************************************************** ;*** Document Type : Service Access Point Specification ;*** Document Name : mnlc ;*** Document No. : 8443.104.02.003 ;*** Document Date : 2002-10-25 ;*** Document Status: SUBMITTED ;*** Document Author: TML ;******************************************************************************** PRAGMA SRC_FILE_TIME "Thu Nov 29 09:48:12 2007" PRAGMA LAST_MODIFIED "2002-10-25" PRAGMA ID_AND_VERSION "8443.104.02.003" CONST L_MAX_CALLED_BCD_NO_LENGTH 10 ; Max Bcd number length (digits) CONST CURSOR_SMS_TEXT_140 140 ; Position SMS Message VALTAB VAL_data_valid VAL 0 DATA_VALID "" VAL 1 DATA_INVALID "" VAR reference "Reference" S VAR bcd "Bcd Number" B VAR data_valid "Cursor Data Valid" B VAL @p_mnlc - VAL_data_valid@ VAR number_length "Number of decimal digits in the Bcd number" B VAR sms_text "SMS text" B COMP called_party_bcd_num "called Party Bcd number" { number_length ; Number Length bcd [L_MAX_CALLED_BCD_NO_LENGTH] ; Bcd Number } ; MNLC_SMS_MEAS_REQ 0x80000044 ; MNLC_SMS_MEAS_CNF 0x80004044 PRIM MNLC_SMS_MEAS_REQ 0x80000044 { reference ; Reference SMS request called_party_bcd_num ; Called Bcd Number } PRIM MNLC_SMS_MEAS_CNF 0x80004044 { reference ; Reference SMS request data_valid ; Cursor Data Valid sms_text [CURSOR_SMS_TEXT_140] ; Cursor SMS }