view src/condat/com/inc/gprs.h @ 220:0ed36de51973

ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents 4e78acac3d88
children
line wrap: on
line source

/*
+-----------------------------------------------------------------------------
|  Project :
|  Modul   :
+-----------------------------------------------------------------------------
|  Copyright 2002 Texas Instruments Berlin, AG
|                 All rights reserved.
|
|                 This file is confidential and a trade secret of Texas
|                 Instruments Berlin, AG
|                 The receipt of or possession of this file does not convey
|                 any rights to reproduce or disclose its contents or to
|                 manufacture, use, or sell anything it may describe, in
|                 whole, or in part, without the specific written consent of
|                 Texas Instruments Berlin, AG.
+-----------------------------------------------------------------------------
|  Purpose :  Contains common definitions for the GPRS Protocol Stack.
+-----------------------------------------------------------------------------
*/

#ifndef GPRS_H
#define GPRS_H

/*
 * The names of the GPRS entities
 */

#define ACI_NAME              "MMI"     /* according to custom.h */
#define PPP_NAME              "PPP"
#define UART_NAME             "UART"
#define PSI_NAME              "PSI"
#define SNDCP_NAME            "SND"
#define SM_NAME               "SM"
#define GMM_NAME              "GMM"
#define GSMS_NAME             "SMS"
#define SMS_NAME              "SMS"     /* according to custom.h */
#define MM_NAME               "MM"
#define LLC_NAME              "LLC"
#define GRR_NAME              "GRR"
#define GRLC_NAME             "GRLC"
#define CCI_NAME              "CCI"
#define L1_NAME               "L1"
#define RR_NAME               "RR"
#define PL_NAME               "PL"      /* according to custom.h */
#define SIM_NAME              "SIM"     /* according to custom.h */
#define TIL_NAME              "PL"
#define UPM_NAME              "UPM"
#define GDD_DIO_NAME          "GDDI"
#define APP_NAME              "APP"

#ifndef _TARGET_
  #define CLT_NAME            "CLT"   /* Used only during Simulation testing*/
#endif /*!_TARGET_*/

/*
 * TRACE_PRIMITVE is no more necessary when using NEW_FRAME.
 * Remove it sometime.
 */

#undef TRACE_PRIMITIVE
#define TRACE_PRIMITIVE(s)    /* s */


#endif /* !GPRS_H */