FreeCalypso > hg > fc-tourmaline
view src/condat/frame/config/gprsinit.c @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Nucleus Entry Function Application_Initialize() +----------------------------------------------------------------------------- */ #ifndef _TARGET_ #define NEW_ENTITY #endif /*==== INCLUDES ===================================================*/ #ifdef _TARGET_ #include "uart/serialswitch.h" #endif #include "nucleus.h" #include "typedefs.h" #include "os.h" #include "vsi.h" #include "os_types.h" #include "pcon.h" #include "p_mem.h" /*==== CONSTANTS ==================================================*/ /*==== TYPES ======================================================*/ /*==== EXTERMALS ==================================================*/ #ifndef _TARGET_ extern void GpInitTarget (void); extern void Cust_Init_Layer1 (void); extern void GpUnmaskInterrupts (void); extern void GpInitExternalDevices (void); #endif /*==== PROTOTYPES =================================================*/ short StartFrame (void); /*==== VARIABLES ==================================================*/ T_PCON_PROPERTIES *pcon = NULL; T_MEM_PROPERTIES *mem = NULL; /*==== FUNCTIONS ==================================================*/ #ifdef _TARGET_ void DummyCallback ( void ) { } #endif /* +--------------------------------------------------------------------+ | PROJECT : GSM-PS (6147) MODULE : GPRSINIT | | STATE : code ROUTINE : Application_Initialize | +--------------------------------------------------------------------+ PURPOSE : Main entry function for NUCLEUS */ /* * NOTE: Application_Initalize() must not be used when compiling for target, * because it is already defined in a TI lib (as of TI 5.1.1). */ #ifndef _TARGET_ void Application_Initialize (void *first_available_memory) { #ifdef _TARGET_ GpInitTarget (); Cust_Init_Layer1 (); GpInitExternalDevices (); SER_tr_Init ( 0, 2, DummyCallback ); #endif StartFrame(); #ifdef _TARGET_ GpUnmaskInterrupts (); #endif } #endif /* !_TARGET_ */ /* +----------------------------------------------------------------------+ | PROJECT : xxx MODULE : GPRSINIT | | STATE : code ROUTINE : InitializeApplication | +----------------------------------------------------------------------+ PURPOSE : General initialization function to be filled with application specific initializations. Function is called by the frame after creation of all tasks prior to the starting of the tasks. */ void InitializeApplication ( void ) { /* * It has to defined if the allocated partition memory shall be * initialized with a dedicated pattern. Select * ENABLE_PARTITON_INIT or DISABLE_PARTITON_INIT * and a pattern to be used for initialization */ #ifdef _TARGET_ vsi_m_init ( DISABLE_PARTITON_INIT, (char)0x00 ); #else vsi_m_init ( ENABLE_PARTITON_INIT, (char)0x00 ); #endif #ifdef _TARGET_ /* * The RTOS tick has to be set.Currently it can be set to * SYSTEM_TICK_TDMA_FRAME for the TDMA frame system tick of 4.615ms * or * SYSTEM_TICK_10_MS for the 10ms tick used for UMTS */ os_set_tick ( SYSTEM_TICK_TDMA_FRAME ); #endif }