FreeCalypso > hg > fc-tourmaline

view src/cs/drivers/drv_core/abb/abb_core_inth.h @ 220:0ed36de51973

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents 4e78acac3d88
children
line wrap: on
line source

/**********************************************************************************/
/*            TEXAS INSTRUMENTS INCORPORATED PROPRIETARY INFORMATION              */
/*                                                                                */
/*   Property of Texas Instruments -- For  Unrestricted  Internal  Use  Only      */
/*   Unauthorized reproduction and/or distribution is strictly prohibited.  This  */
/*   product  is  protected  under  copyright  law  and  trade  secret law as an  */
/*   unpublished work.  Created 1987, (C) Copyright 1997 Texas Instruments.  All  */
/*   rights reserved.                                                             */
/*                                                                                */
/*                                                                                */
/*   Filename          : abb_core_inth.h                                          */
/*                                                                                */
/*   Description       : Functions to manage the ABB device interrupt.            */
/*                       The Serial Port Interface is used to connect the TI 	    */
/*	          					 Analog BaseBand (ABB).                                   */
/*						           It is assumed that the ABB is connected as the SPI       */																				  
/*                       device 0, and ABB interrupt is mapped as external IT.    */																				  
/*																				                                        */
/*   Author            : Pascal PUEL                                              */
/*                                                                                */
/*   Version number   : 1.0                                                       */
/*                                                                                */
/*   Date and time    : Jan 2003                                                  */
/*                                                                                */
/*   Previous delta   : Creation                                                  */
/*                                                                                */
/**********************************************************************************/
/*                                                                                */
/*   17/12/03                                                                     */
/*   The original abb_inth.h has been splitted between the actual abb_inth.h      */
/*   located in drv_apps directory and abb_inth_core.h located in drv_core        */
/*   directory.                                                                   */
/*                                                                                */
/**********************************************************************************/

#ifndef __ABB_CORE_INTH_H__
#define __ABB_CORE_INTH_H__

  #include "l1sw.cfg"

  #if (OP_L1_STANDALONE == 0)
    #include "main/sys_types.h"
  #else
    #include "sys_types.h"
  #endif

  #ifndef _WINDOWS

    #include "chipset.cfg"
  
    // Structure definition for ADC READING RESULT REPORTS
    // Define the maximum number of measures performed by the MADC module
    #if ((ANLG_FAM == 1) || (ANLG_FAM == 3))
      #define MADC_NUMBER_OF_MEAS  (9)
    #endif
    #if (ANLG_FAM == 2)
      #define MADC_NUMBER_OF_MEAS  (8)
    #endif
  
    typedef struct
    {
      SYS_UWORD16 adc_result[MADC_NUMBER_OF_MEAS];
    } T_CST_ADC_RESULT;
  
  #else   // _WINDOWS
  
    #define MADC_NUMBER_OF_MEAS  (8)

  #endif   // _WINDOWS


  // PROTOTYPES
  #ifndef _WINDOWS
    void Create_ABB_HISR(void);
    SYS_BOOL Activate_ABB_HISR(void);
  #endif   // _WINDOWS
  
  void EXT_HisrEntry(void);


#endif  // __ABB_CORE_INTH_H__