FreeCalypso > hg > fc-tourmaline
view src/cs/layer1/include/l1_macro.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/************* Revision Controle System Header ************* * GSM Layer 1 software * L1_MACRO.H * * Filename l1_macro.h * Copyright 2003 (C) Texas Instruments * ************* Revision Controle System Header *************/ #include "l1_confg.h" #if(L1_DYN_DSP_DWNLD == 1) #include "l1_dyn_dwl_const.h" #endif #if (TRACE_TYPE==5) && NUCLEUS_TRACE //WARNING : this type of trace takes a lot of space in data RAM (~16kB) // switch for Nucleus debugging messages. #define NU_ALLOC_ERR 0 #define NU_DEALLOC_ERR 1 #define NU_RCVE_QUEUE_ERR 2 #define NU_SEND_QUEUE_ERR 3 #define NU_OBTA_SEMA_ERR 4 #define NU_RLSE_SEMA_ERR 5 // Nucleus debug function. #define DEBUGMSG(status,type) \ if(status) switch(type) \ { \ case NU_ALLOC_ERR: \ printf("NU mem. allocation error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ \ case NU_DEALLOC_ERR: \ printf("NU mem. deallocation error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ \ case NU_RCVE_QUEUE_ERR: \ printf("NU rcve queue error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ \ case NU_SEND_QUEUE_ERR: \ printf("NU send queue error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ \ case NU_OBTA_SEMA_ERR: \ printf("NU obtain semaph. error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ \ case NU_RLSE_SEMA_ERR: \ printf("NU release semaph. error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ \ default: \ printf("Unknown error %d file %s line %d\n", status,__FILE__,__LINE__); \ exit(0); \ break; \ } #else #define DEBUGMSG(status,type) #endif /************************************************************/ /* Macros for FAST INTEGER MODULO implementation. */ /************************************************************/ #define IncMod(operand, increment, modulo) \ if( (operand += increment) >= modulo ) operand -= modulo // Define MACRO for selecting the min. time to next task. #define Select_min_time(Task_Time, Min_Time) \ if(Task_Time < Min_Time) Min_Time = Task_Time; /************************************************************/ /* Macros for MCU/DSP API address conversion . */ /************************************************************/ #if(L1_DYN_DSP_DWNLD == 1) #define API_address_dsp2mcu(dsp_address) \ (MCU_API_BASE_ADDRESS + ((API)((dsp_address) - DSP_API_BASE_ADDRESS) * 2)) #define API_address_mcu2dsp(mcu_address) \ (DSP_API_BASE_ADDRESS + ((UWORD32)((mcu_address) - MCU_API_BASE_ADDRESS) / 2)) #endif