FreeCalypso > hg > fc-tourmaline
view src/cs/riviera/rvt/rvt_def_i.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/******************************************************************************* * * rvt_def_i.h * * (C) Texas Instruments, all rights reserved * * Version number : 0.1 * * History : 0.1 (7/5/2000) - Created * * Date : 7/5/2000 * * Author : Guido Pagana g-pagana@ti.com * ******************************************************************************/ #ifndef __RVT_DEF_I_H__ #define __RVT_DEF_I_H__ #include "rvt/rvt_gen.h" #include "rvt/rvt_pool_size.h" /* Stack & Memory Bank sizes definitions */ /************************* Internal definitions **************************/ /* Define the maximum number of msg lost before sending an alert */ #define RVT_MAX_LOST_TRACE_MSG (1) /* Trace user database (must end using RVT_END_OF_TABLE) */ #define RVT_END_OF_TABLE {"", RVT_INVALID_HEADER, NULL} #define RVT_USER_ID_MAPPING { \ {"RV", RVT_RV_HEADER, NULL}, \ {"L1", RVT_L1_HEADER, NULL}, \ {"L23", RVT_L23_HEADER, NULL}, \ {"TM", RVT_TM_HEADER, NULL}, \ {"RNET", RVT_RNET_HEADER, NULL}, \ {"PROF", RVT_PROF_HEADER, NULL}, \ {"GTTBACK", RVT_GTTBACK_HEADER, NULL}, \ {"OTHER", RVT_OTHER_HEADER, NULL}, \ {"AT", RVT_AT_HEADER, NULL}, \ {"EXTUI", RVT_EXTUI_HEADER, NULL}, \ {"TCH", RVT_TCH_HEADER, NULL}, \ {"KEEPALIVE", RVT_KEEPALIVE_HEADER, NULL}, \ RVT_END_OF_TABLE \ } /* Trace task mailbox */ #define RVT_TRACE_MAILBOX RVF_TASK_MBOX_0 typedef struct { T_RVT_NAME user_name[RVT_NAME_MAX_LEN]; T_RVT_USER_ID user_id; RVT_CALLBACK_FUNC rx_callback_func; } T_RVT_USER_DB; /* Define the unique message type used in RVT */ #define RVT_TRACE_RQST_ID ( (RVT_USE_ID & 0xFFFF0000) | ( 0x1) | 0x001) typedef struct { T_RV_HDR header; T_RVT_USER_ID user_id; T_RVT_FORMAT format; T_RVT_MSG_LG msg_length; } T_RVT_TRACE_RQST; /* Trace message header size */ #define RVT_HEADER_SIZE (sizeof(T_RVT_TRACE_RQST) ) #define TRACE_TASK_STACK_SIZE TRACE_STACK_SIZE #define TRACE_MB_SIZE (TRACE_MB1_SIZE) #define TRACE_MB_WATERMARK (TRACE_MB_SIZE) /* Decimal to hexadecimal conversion table */ static const char Num2Char[] = {'0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F'}; /* ** Number of messages lost. Causes: ** ** __ 'Format' differs from RVT_ASCII_FORMAT and RVT_BINARY_FORMAT. ** | __ 'Message ID' differs from RVT_TRACE_RQST_ID. ** | | __ rvf_read_mbox has returned NULL. ** | | | __ Failed to send the message. ** | | | | __ Insufficient resources. ** | | | | | __ Trace Module not started. ** |_|_|_|_|_|____________________________________________________ ** | ¦ ¦ ¦ ¦ ¦ ¦ | | | | ** | ¦ ¦ ¦ ¦ ¦ ¦ | | | | ** |_¦_¦_¦_¦_¦_¦_._|_._._._._._._._|_._._._._._._._|_._._._._._._._| */ typedef union { struct { INT32 count : 26; INT32 not_started : 1; INT32 insufficient_resources : 1; INT32 message_not_sent : 1; INT32 message_empty : 1; INT32 unknown_request : 1; INT32 unknown_format : 1; } bit_mask; UINT32 overall_value; } T_RVT_LOST_MSG; extern T_RVT_LOST_MSG rvt_lost_msg_cpt; /* Prototypes */ BOOLEAN rvt_name_cmp( char * str1, char * str2); void rvt_activate_RX_HISR (void); void rvt_RX_process (void); #endif /* __RVT_DEF_I_H__ */