FreeCalypso > hg > fc-tourmaline
view src/cs/services/audio/audio_compatibilities.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/****************************************************************************/ /* */ /* File Name: audio_compatibilities.h */ /* */ /* Purpose: This file contains the compatibilities table between the */ /* audio feature as describe in the S916 specification (annex) */ /* */ /* Version 0.1 */ /* */ /* Date Modification */ /* ------------------------------------ */ /* 12 November 2001 Create */ /* */ /* Author Francois Mazard */ /* */ /* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/ /****************************************************************************/ #include "rv/rv_defined_swe.h" #ifdef RVM_AUDIO_MAIN_SWE #ifndef __AUDIO_COMPATIBILITIES_H_ #define __AUDIO_COMPATIBILITIES_H_ #ifdef __cplusplus extern "C" { #endif /* Define the number of audio features */ #define AUDIO_NUMBER_OF_FEATURES (13) typedef struct { BOOLEAN feature[AUDIO_NUMBER_OF_FEATURES]; } T_AUDIO_ACTIVE_FEATURE; /* Define the list of the audio features */ #define AUDIO_KEYBEEP_FEATURE (0) #define AUDIO_TONES_FEATURE (1) #define AUDIO_MELODY_E1_FEATURE (2) #define AUDIO_VOICE_MEMO_PLAY_FEATURE (3) #define AUDIO_VOICE_MEMO_RECORD_FEATURE (4) #define AUDIO_SR_ENROLL_FEATURE (5) #define AUDIO_SR_UPDATE_FEATURE (6) #define AUDIO_SR_RECO_FEATURE (7) #define AUDIO_MELODY_E2_FEATURE (8) #define AUDIO_TTY_FEATURE (9) #define AUDIO_VOICE_MEMO_AMR_PLAY_FEATURE (10) #define AUDIO_VOICE_MEMO_AMR_RECORD_FEATURE (11) #define AUDIO_MIDI_FEATURE (12) /* It isn't a starting message */ #define AUDIO_NO_START_MESSAGE (-1) typedef struct { BOOLEAN compatibilities_flag[AUDIO_NUMBER_OF_FEATURES]; } T_AUDIO_COMPATIBILITES; #ifdef __cplusplus } #endif #endif /* __AUDIO_COMPATIBILITIES_H_ */ #endif /* #ifdef RVM_AUDIO_MAIN_SWE */