FreeCalypso > hg > fc-tourmaline
view src/cs/services/audio/audio_env_i.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/****************************************************************************/ /* */ /* File Name: audio_env_i.h */ /* */ /* Purpose: This file contains prototypes for BT Environment related */ /* functions used to get info, start and stop the audio block. */ /* */ /* Version 0.1 */ /* */ /* Date Modification */ /* ------------------------------------ */ /* 18 May 2001 Create */ /* */ /* Author Francois Mazard - Stephanie Gerthoux */ /* */ /* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/ /****************************************************************************/ #ifndef _WINDOWS #include "config/l1sw.cfg" #include "config/swconfig.cfg" #endif #include "rv/rv_defined_swe.h" #ifdef RVM_AUDIO_MAIN_SWE #include "l1audio_cust.h" #include "audio/audio_structs_i.h" #include "audio/audio_pool_size.h" /* Stack & Memory Bank sizes definitions */ #ifndef __AUDIO_ENV_H_ #define __AUDIO_ENV_H_ /* memory bank size and watermark */ #define AUDIO_MB_EXTERNAL_SIZE AUDIO_MB1_SIZE #define AUDIO_MB_EXTERNAL_WATERMARK AUDIO_MB_EXTERNAL_SIZE #define AUDIO_MB_INTERNAL_SIZE AUDIO_MB2_SIZE #define AUDIO_MB_INTERNAL_WATERMARK AUDIO_MB_INTERNAL_SIZE #if (!GSMLITE) #if (SPEECH_RECO) /* In case of the speech reco, the RAM used is for the word speech sample recording */ /* 2 corresponds to sizeof(UINT16) */ #define AUDIO_MB_FFS_SIZE ( (SC_SR_MMI_2_L1_SPEECH_SIZE * 2)\ + (SC_SR_MMI_DB_MODEL_SIZE * 2) +\ (AUDIO_SR_MAX_VOCABULARY_NAME * AUDIO_PATH_NAME_MAX_SIZE)\ + 100 ) #else #define AUDIO_MB_FFS_SIZE AUDIO_MB3_SIZE #endif #define AUDIO_MB_FFS_WATERMARK AUDIO_MB_FFS_SIZE #endif /* generic functions declarations */ T_RVM_RETURN audio_get_info (T_RVM_INFO_SWE *infoSWEnt); T_RVM_RETURN audio_set_info(T_RVF_ADDR_ID addrId, T_RV_RETURN return_path[], T_RVF_MB_ID mbId[], T_RVM_RETURN (*callBackFct) ( T_RVM_NAME SWEntName, T_RVM_RETURN errorCause, T_RVM_ERROR_TYPE errorType, T_RVM_STRING errorMsg) ); T_RVM_RETURN audio_init (void); T_RVM_RETURN audio_stop (void); T_RVM_RETURN audio_kill (void); #endif /*__AUDIO_ENV_H_*/ #endif /* #ifdef RVM_AUDIO_MAIN_SWE */