FreeCalypso > hg > fc-tourmaline
view src/cs/services/audio/audio_error_hdlr_i.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/****************************************************************************/ /* */ /* File Name: audio_error_hdlr_i.h */ /* */ /* Purpose: This file contains routines used to report unrecoverable */ /* memory errors that might occur. */ /* */ /* Version 0.1 */ /* */ /* Date Modification */ /* ------------------------------------------------------------------------*/ /* 14 May 2001 Create */ /* */ /* Author Francois Mazard - Stephanie Gerthoux */ /* */ /* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/ /****************************************************************************/ #include "rv/rv_defined_swe.h" #ifdef RVM_AUDIO_MAIN_SWE #ifndef _AUDIO_ERROR_HDLR_I_H #define _AUDIO_ERROR_HDLR_I_H #include "l1_confg.h" /* error trace functions prototypes */ #if (KEYBEEP) void audio_keybeep_error_trace(UINT8 error_id); #endif #if (TONE) void audio_tones_error_trace(UINT8 error_id); #endif #if (MELODY_E1) void audio_melody_E1_error_trace(UINT8 error_id); #endif #if (MELODY_E2) void audio_melody_E2_error_trace(UINT8 error_id); #endif #if (VOICE_MEMO) void audio_voice_memo_error_trace(UINT8 error_id); #endif void audio_mode_error_trace(UINT8 error_id); #if (SPEECH_RECO) void audio_sr_error_trace(UINT8 error_id); #endif #if (MELODY_E1) || (VOICE_MEMO) || (SPEECH_RECO) void audio_ffs_error_trace(UINT8 error_id); #endif #if (L1_VOICE_MEMO_AMR) void audio_voice_memo_amr_error_trace(UINT8 error_id); #endif #if (L1_AUDIO_DRIVER) void audio_driver_error_trace(UINT8 error_id); #endif #if (AUDIO_MEM_MANAGER) void audio_mem_error_trace(UINT8 error_id); #endif /* extern prototype */ extern void audio_error_trace(UINT8 error_id); #if (L1_MIDI==1) void audio_midi_error_trace(UINT8 error_id); #endif /* Id of the error trace */ #define AUDIO_ENTITY_NOT_START (0) #define AUDIO_ENTITY_NO_MEMORY (1) #define AUDIO_ERROR_STOP_EVENT (2) #define AUDIO_ERROR_START_EVENT (3) #define AUDIO_ERROR_INIT_EVENT (4) #define AUDIO_ERROR_FREE_EVENT (5) #define AUDIO_ENTITY_BAD_PARAMETER (6) #define AUDIO_ENTITY_BAD_MESSAGE (7) #define AUDIO_ERROR_MODE (8) #define AUDIO_ENTITY_FILE_ERROR (9) #define AUDIO_ENTITY_FILE_NO_SAVED (10) #define AUDIO_ENTITY_FILE_ALREADY_EXIST (11) #define AUDIO_ENTITY_FILE_NO_CLOSE (12) #define AUDIO_ENTITY_SPEECH_NO_SAVED (13) #define AUDIO_ENTITY_MODEL_NO_SAVED (14) #define AUDIO_ENTITY_BAD_DATABASE (15) #define AUDIO_ENTITY_MODEL_NO_LOAD (16) #define AUDIO_ENTITY_AUDIO_MODE_NO_LOADED (17) #define AUDIO_ERROR_DOWNLOAD (18) #define AUDIO_ERROR_NOT_DOWNLOAD (19) #define AUDIO_ENTITY_LOAD_FILE_INSTR_ERROR (20) #define AUDIO_ERROR_INSTRUMENT_SIZE (21) #define AUDIO_FEATURE_NOT_COMPILED (22) #define AUDIO_ERROR_L1_START_EVENT (23) #define AUDIO_ERROR_L1_STOP_EVENT (24) #endif #endif /* #ifdef RVM_AUDIO_MAIN_SWE */