FreeCalypso > hg > fc-tourmaline
view src/cs/services/etm/etm_env.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/******************************************************************************** * Enhanced TestMode (ETM) * @file etm_env.h * * Declarations of the Riviera Generic Functions * (except handle message and handle timer). * * @author aurent Sollier (l-sollier@ti.com) and Kim T. Peteren (ktp@ti.com) * @version 0.1 * * * History: * * Date Modification * ------------------------------------ * 10/24/2001 Creation * * (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved *********************************************************************************/ #ifndef _ETM_ENV_H_ #define _ETM_ENV_H_ #include "rvm/rvm_gen.h" #include "etm/etm_pool_size.h" /* Stack & Memory Bank sizes definitions */ /** * Mailbox ID used by the SWE. */ #define ETM_MAILBOX RVF_TASK_MBOX_0 /** * @name Mem bank * Memory bank size and watermark. */ /*@{*/ #define ETM_MB_PRIM_SIZE ETM_MB1_SIZE #define ETM_MB_PRIM_WATERMARK ETM_MB_PRIM_SIZE /*@}*/ /** Define a structure used to store all the informations related to KPD's task * & MBs identifiers. */ typedef struct ctrl_blk { T_RVF_MB_ID prim_id; T_RVF_ADDR_ID addr_id; T_RVM_RETURN (*error_ft)(T_RVM_NAME swe_name, T_RVM_RETURN error_cause, T_RVM_ERROR_TYPE error_type, T_RVM_STRING error_msg); } T_ETM_ENV_CTRL_BLK; /** * @name Generic functions * Generic functions declarations. */ /*@{*/ T_RVM_RETURN etm_get_info(T_RVM_INFO_SWE *infoSWE); T_RVM_RETURN etm_set_info( T_RVF_ADDR_ID addr_id, T_RV_RETURN return_path[], T_RVF_MB_ID bk_id[], T_RVM_RETURN (*rvm_error_ft)(T_RVM_NAME swe_name, T_RVM_RETURN error_cause, T_RVM_ERROR_TYPE error_type, T_RVM_STRING error_msg)); T_RVM_RETURN etm_init(void); T_RVM_RETURN etm_start(void); T_RVM_RETURN etm_stop(void); T_RVM_RETURN etm_kill(void); /*@}*/ #endif /* #ifndef _ETM_ENV_H_ */