FreeCalypso > hg > fc-tourmaline

view src/g23m-aci/aci/aci_cphs.h @ 220:0ed36de51973

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: GSM-F&D (8411)               $Workfile:: aci_cphs.h      $|
| $Author:: $ CONDAT AG                 $Revision::                 $|
| CREATED:                              $Modtime::                  $|
| STATE  : code                                                      |
+--------------------------------------------------------------------+

   MODULE  : ACI_CPHS

   PURPOSE : Command handler interface definitions for CPHS

*/

#ifdef FF_CPHS

#ifndef ACI_CPHS_H
#define ACI_CPHS_H

/**************** CPHS Module *****************************************/
EXTERN T_ACI_RETURN sAT_PercentCPHS( T_ACI_CMD_SRC   srcId,
                                     T_ACI_CPHS_INIT init_cphs );

EXTERN T_ACI_RETURN qAT_PercentCPHS( T_ACI_CMD_SRC   srcId,
                                     T_ACI_CPHS_INIT *init_cphs);

EXTERN T_ACI_RETURN sAT_PercentCPNUMS( T_ACI_CMD_SRC srcId,
                                       UBYTE         element_id,
                                       UBYTE         mode );

EXTERN T_ACI_RETURN tAT_PercentCPNUMS( T_ACI_CMD_SRC srcId );

EXTERN T_ACI_RETURN qAT_PercentCPALS( T_ACI_CMD_SRC srcId,
                                      UBYTE         call_id,
                                      T_CPHS_LINES  *line,
                                      CHAR          *line_desc,
                                      UBYTE         *max_line_desc);

EXTERN T_ACI_RETURN sAT_PercentCPVWI( T_ACI_CMD_SRC srcId,
                                      UBYTE         flag_set, 
                                      USHORT        lines);

EXTERN T_ACI_RETURN qAT_PercentCPVWI( T_ACI_CMD_SRC srcId,
                                      UBYTE         *flag_set, 
                                      USHORT        line);

EXTERN T_ACI_RETURN qAT_PercentCPOPN( T_ACI_CMD_SRC srcId,
                                      CHAR         *longname, 
                                      UBYTE        *max_longname,
                                      CHAR         *shortname, 
                                      UBYTE        *max_shortname);

EXTERN T_ACI_RETURN sAT_PercentCPINF( T_ACI_CMD_SRC srcId,
                                      UBYTE         *csp,
                                      UBYTE         csp_len);

EXTERN T_ACI_RETURN qAT_PercentCPINF( T_ACI_CMD_SRC srcId,
                                      UBYTE        *phase,
                                      USHORT       *sst,
                                      CHAR         *csp,
                                      CHAR         *csp2,
                                      UBYTE        *max_csp_size,
                                      UBYTE        *max_csp2_size);

EXTERN T_ACI_RETURN qAT_PercentCPMB( T_ACI_CMD_SRC  srcId,
                                      UBYTE         rec_id,
                                      T_CPHS_LINES  *line,
                                      CHAR          *number,
                                      T_ACI_TOA_TON *ton,
                                      T_ACI_TOA_NPI *npi,
                                      CHAR          *alpha_id,
                                      UBYTE         *first);

EXTERN T_ACI_RETURN sAT_PercentCPMBW( T_ACI_CMD_SRC       srcId,
                                      SHORT               index,
                                      CHAR*               number,
                                      T_ACI_TOA*          type,
                                      T_CPHS_PB_TEXT* text);

GLOBAL T_ACI_RETURN tAT_PercentCPMBW ( T_ACI_CMD_SRC srcId,
                                       SHORT*        firstIdx,
                                       SHORT*        lastIdx,
                                       UBYTE*        nlength,
                                       UBYTE*        tlength );

EXTERN T_ACI_RETURN sAT_PercentCPCFU( T_ACI_CMD_SRC srcId, 
                                      UBYTE         cfu_set, 
                                      T_CPHS_LINES  lines );

EXTERN T_ACI_RETURN qAT_PercentCPCFU( T_ACI_CMD_SRC srcId,
                                      UBYTE *cfu_set, 
                                      T_CPHS_LINES line );


#ifdef CMH_F_C
EXTERN void rCI_PercentCPNUMS(void);
EXTERN void rAT_PercentCPNUMS(void);
EXTERN void rCI_PercentCPVWI (void);
EXTERN void rAT_PercentCPVWI (void);
EXTERN void rCI_PercentCPROAM (void);
EXTERN void rAT_PercentCPROAM (void);


#else
EXTERN void rCI_PercentCPNUMS(UBYTE element_index,
                              UBYTE index_level,
                              CHAR  *alpha_tag,
                              CHAR  *number,
                              BOOL  premium_flag,
                              BOOL  network_flag,
                              UBYTE type_of_address);
                              

EXTERN void rAT_PercentCPNUMS(UBYTE element_index,
                              UBYTE index_level,
                              CHAR  *alpha_tag,
                              CHAR  *number,
                              BOOL  premium_flag,
                              BOOL  network_flag,
                              UBYTE type_of_address);
                              

EXTERN void rCI_PercentCPVWI (UBYTE  flag_set, 
                              USHORT line);
EXTERN void rAT_PercentCPVWI (UBYTE  flag_set, 
                              USHORT line);

EXTERN void rCI_PercentCPROAM (UBYTE roam_status);
EXTERN void rAT_PercentCPROAM (UBYTE roam_status);

#endif /* CMH_F_C */



/**********************************************************************/


#endif /* ACI_CPHS_H */
#endif /* FF_CPHS */

/*==== EOF ========================================================*/