FreeCalypso > hg > fc-tourmaline

view src/g23m-aci/aci/aci_csf.c @ 220:0ed36de51973

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-F&D (8411)
|  Modul   :  ACI_CSF
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  This Modul defines the custom specific functions for the
|             AT Command Interpreter
+----------------------------------------------------------------------------- 
*/ 

#ifndef ACI_CSF_C
#define ACI_CSF_C

#include "aci_all.h"

#include "aci_cmh.h"

#ifdef FF_ATI
#include "ati_cmd.h"
#endif

#include "aci_cmd.h"
#include "aci.h"

/*==== CONSTANTS ==================================================*/

/*==== TYPES ======================================================*/

/*==== EXPORT =====================================================*/

/*==== VARIABLES ==================================================*/

/*==== FUNCTIONS ==================================================*/
/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)              MODULE  : ACI_CSF            |
| STATE   : code                        ROUTINE : aci_init_timer     |
+--------------------------------------------------------------------+

  PURPOSE : Initialize the ACI timer.

*/

GLOBAL void aci_init_timer (void)
{
  TRACE_FUNCTION ("aci_init_timer()");

#if !defined (NEW_FRAME)

#ifdef FF_ATI
  t_ring_handle = vsi_t_open (VSI_CALLER TRING );
#endif
  t_ect_handle  = vsi_t_open (VSI_CALLER TMPTY );
  t_mpty_handle = vsi_t_open (VSI_CALLER TMPTY );
  t_dtmf_handle = vsi_t_open (VSI_CALLER TDTMF );

#ifdef FAX_AND_DATA
  t_fit_handle  = vsi_t_open (VSI_CALLER TFIT );
#endif

#endif
  /* AoC timers are created if AoC is really supported */
}

/*
+--------------------------------------------------------------------+
| PROJECT : GSM-F&D (8411)              MODULE  : ACI_CSF            |
| STATE   : code                        ROUTINE : aci_exit_timer     |
+--------------------------------------------------------------------+

  PURPOSE : Closes all timer.

*/

GLOBAL void aci_exit_timer (void)
{
  TRACE_FUNCTION ("aci_exit_timer()");

#if !defined (NEW_FRAME)

#ifdef FF_ATI
  vsi_t_close (VSI_CALLER t_ring_handle);
  t_ring_handle = VSI_ERROR;
#endif

#ifdef FAX_AND_DATA
  vsi_t_close (VSI_CALLER t_fit_handle);
  t_fit_handle = VSI_ERROR;
#endif

#endif
}

#endif