FreeCalypso > hg > fc-tourmaline
view src/g23m-aci/aci/aci_mfw.c @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-F&D (8411) | Modul : ACI_MFW +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Only for testing of Conc SMS via the ATI. +----------------------------------------------------------------------------- */ #ifndef ACI_MFW_C #define ACI_MFW_C #endif #include "aci_all.h" #include "aci_cmh.h" #include "ati_cmd.h" #include "aci_io.h" #include "aci_cmd.h" #include "aci_fd.h" #include "aci_mem.h" #include "psa.h" #include "psa_sms.h" #include "cmh.h" #include "cmh_sms.h" #include "psa_cc.h" #include "aci_lst.h" #if defined _CONC_TESTING_ AND defined TI_PS_FF_CONC_SMS #include "conc_sms.h" #include "aci_mfw.h" //#define TRACE_CCD /* for CCD Debugging */ /********************************************************************** * TEMPORARY ADAPTION FUNCTIONS * *********************************************************************/ //ALL THE FUNCTIONS BELOW ARE COMMENTED OUT AS THEY WERE FOR TESITNG ONLY GLOBAL void rAT_PlusCMTI_Ext( T_ACI_SMS_STOR mem, UBYTE index, T_ACI_CMGL_SM* sm) { T_SMS_TYPE smsType; T_CONC_ASSEMBLY_RETURN ret; T_SM_DATA_EXT data_conc; TRACE_FUNCTION ("rAT_PlusCMTI_Ext"); smsType = SMS_getSMSType ( &sm->udh, sm->adress, MODE2); if (smsType EQ CONCATE) { ret = concSMS_Collect ( &data_conc, sm, 1, mem); if (ret EQ CONC_COMPLETED) { UBYTE i; for (i=0; i<CMD_SRC_MAX; i++) io_sendMessage(i, (CHAR*)data_conc.data, ATI_NORMAL_OUTPUT); ACI_MFREE(data_conc.data); } } TRACE_EVENT_P1("smsType: %d", smsType); rAT_PlusCMTI( mem, index, sm ); } GLOBAL void rAT_PlusCMT_Ext (T_ACI_CMGL_SM* sm) { T_SMS_TYPE smsType; T_CONC_ASSEMBLY_RETURN ret; T_SM_DATA_EXT data_conc; TRACE_FUNCTION ("rAT_PlusCMT_Ext"); smsType = SMS_getSMSType ( &sm->udh, sm->adress, MODE1); if (smsType EQ CONCATE) { ret = concSMS_Collect ( &data_conc, sm, 0, SMS_STOR_NotPresent); if (ret EQ CONC_COMPLETED) { UBYTE i; for (i=0; i<CMD_SRC_MAX; i++) io_sendMessage(i, (CHAR*)data_conc.data, ATI_NORMAL_OUTPUT); ACI_MFREE(data_conc.data); } } rAT_PlusCMT(sm); } GLOBAL void rAT_PlusCMGR_Ext (T_ACI_CMGL_SM* sm, T_ACI_CMGR_CBM* cbm) { T_SMS_TYPE smsType; T_CONC_ASSEMBLY_RETURN ret; T_SM_DATA_EXT data_conc; TRACE_FUNCTION ("rAT_PlusCMGR_Ext"); smsType = SMS_getSMSType ( &sm->udh, sm->adress, MODE3); if (smsType EQ CONCATE) { ret = concSMS_Collect ( &data_conc, sm, 0, SMS_STOR_NotPresent); if (ret EQ CONC_COMPLETED) { UBYTE i; for (i=0; i<CMD_SRC_MAX; i++) io_sendMessage(i, (CHAR*)data_conc.data, ATI_NORMAL_OUTPUT); ACI_MFREE(data_conc.data); } } rAT_PlusCMGR ( sm, NULL ); } GLOBAL void rAT_PercentCMGR_Ext (T_ACI_CMGL_SM* sm, T_ACI_CMGR_CBM* cbm) { T_SMS_TYPE smsType; T_CONC_ASSEMBLY_RETURN ret; T_SM_DATA_EXT data_conc; TRACE_FUNCTION ("rAT_PercentCMGR_Ext"); smsType = SMS_getSMSType ( &sm->udh, sm->adress, MODE3); if (smsType EQ CONCATE) { ret = concSMS_Collect ( &data_conc, sm, 0, SMS_STOR_NotPresent); if (ret EQ CONC_COMPLETED) { UBYTE i; for (i=0; i<CMD_SRC_MAX; i++) io_sendMessage(i, (CHAR*)data_conc.data, ATI_NORMAL_OUTPUT); ACI_MFREE(data_conc.data); } } rAT_PercentCMGR ( sm, NULL ); } #if !defined _SIMULATION_ AND !defined SMI AND !defined MFW AND !defined FF_MMI_RIV /* This is for conc. testing when compiling for ACI only */ GLOBAL void rAT_PlusCMGS ( UBYTE mr, UBYTE numSeg) {} GLOBAL void rAT_PlusCMS ( T_ACI_AT_CMD cmdId, T_ACI_CMS_ERR err, T_EXT_CMS_ERROR* conc_error) {} GLOBAL void rAT_PlusCMSS ( UBYTE mr, UBYTE numSeg) {} GLOBAL void rAT_PlusCMGD ( ) {} GLOBAL void rAT_PlusCMGW ( UBYTE index, UBYTE numSeg, UBYTE mem) {} GLOBAL void rAT_PlusCMGC ( UBYTE mr) {} GLOBAL void rAT_PlusCMGR ( T_ACI_CMGL_SM* sm, T_ACI_CMGR_CBM* cbm ) {} GLOBAL void rAT_PlusCMTI ( T_ACI_SMS_STOR mem, UBYTE index, T_ACI_CMGL_SM* sm) {} GLOBAL void rAT_PlusCMT ( T_ACI_CMGL_SM* sm) {} #endif /* #if !defined _SIMULATION_ AND !defined SMI AND !defined MFW AND !defined FF_MMI_RIV */ #endif /* #ifdef _CONC_TESTING_ */