view src/g23m-aci/aci/cmh_l2r.h @ 220:0ed36de51973

ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  CMH_L2R
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Definitions for the command handler of Layer 2 Relay
+----------------------------------------------------------------------------- 
*/ 

#ifndef CMH_L2R_H
#define CMH_L2R_H

/*==== CONSTANTS ==================================================*/


/*==== TYPES ======================================================*/

typedef struct entL2rStatus          /* entity status */
{
  T_ACI_CMD_SRC  entOwn;          /* entity owner */
  T_ACI_AT_CMD   curCmd;          /* current command processing */
  BOOL           isTempDisconnected;            
} T_L2R_ENT_STAT;

/*==== PROTOTYPES =================================================*/

GLOBAL void cmhL2R_TRA_Enabled ( void );
GLOBAL void cmhL2R_Deactivated ( void );
GLOBAL void cmhTRA_Deactivated ( void );

#ifdef DTI
GLOBAL void cmhL2R_TRA_Disabled ( T_DTI_ENTITY_ID entityId);
#endif

GLOBAL void cmhL2R_Failure ( void );

GLOBAL SHORT        cmhL2R_GetCompDir ( void );
GLOBAL UBYTE        cmhL2R_SelCompDir ( T_L2R_CMD_PRM * pCmdPrm );
GLOBAL UBYTE        cmhL2R_SelChnRate ( void );
GLOBAL T_ACI_RETURN cmhL2R_Activate   ( T_ACI_CMD_SRC srcId,
                                        T_ACI_AT_CMD cmdId,
                                        SHORT cId );
GLOBAL T_ACI_RETURN cmhL2R_Deactivate ( void );
GLOBAL T_ACI_RETURN cmhTRA_Deactivate ( void );

#ifdef DTI
GLOBAL void cmhCC_L2R_or_TRA_Activated ( T_DTI_ENTITY_ID activated_module, SHORT cId );
#endif /* DTI */
GLOBAL void cmhCC_L2R_or_TRA_Deactivated ( SHORT cId );

#ifdef DTI
GLOBAL BOOL TRA_connect_dti_cb(UBYTE dti_id, T_DTI_CONN_STATE result_type); 
GLOBAL BOOL L2R_connect_dti_cb(UBYTE dti_id, T_DTI_CONN_STATE result_type); 
#endif /* DTI */


GLOBAL T_ACI_RETURN cmhL2R_Enable     ( void );


/*==== EXPORT =====================================================*/
#ifdef CMH_L2RF_C

GLOBAL T_L2R_ENT_STAT l2rEntStat;

#else

EXTERN T_L2R_ENT_STAT l2rEntStat;

#endif /* CMH_L2RF_C */


#endif /* CMH_L2R_H */

/*==== EOF =======================================================*/