FreeCalypso > hg > fc-tourmaline
view src/g23m-aci/aci/cmh_phbr.c @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-PS (6147) | Modul : CMH_PHBR +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This module defines the functions which are responsible | for the responses of the protocol stack adapter for | the phonebook management. +----------------------------------------------------------------------------- */ #ifndef CMH_PHBR_C #define CMH_PHBR_C #endif #include "aci_all.h" /*==== INCLUDES ===================================================*/ #include "aci_cmh.h" #include "ati_cmd.h" #include "aci_cmd.h" #include "aci.h" #ifdef FAX_AND_DATA #include "aci_fd.h" #endif /* of #ifdef FAX_AND_DATA */ #include "psa.h" #include "psa_cc.h" #include "psa_sim.h" #include "cmh.h" #include "phb.h" #include "aci_lst.h" #include "conc_sms.h" /*==== CONSTANTS ==================================================*/ /*==== TYPES ======================================================*/ /*==== EXPORT =====================================================*/ /*==== VARIABLES ==================================================*/ /*==== FUNCTIONS ==================================================*/ /* +-------------------------------------------------------------------+ | PROJECT : GSM-PS (6147) MODULE : CMH_PHBR | | ROUTINE : cmhPHB_StatIndication | +-------------------------------------------------------------------+ PURPOSE : */ GLOBAL SHORT cmhPHB_StatIndication ( T_PHB_STAT psaStatus, SHORT cmeError, BOOL indicate ) { UBYTE idx; /* used for counting */ T_PHB_CMD_PRM * pPHBCmdPrm; TRACE_FUNCTION ("cmhPHB_StatIndication()"); switch ( psaStatus ) { case ( PHB_READY ): { simShrdPrm.pb_stat = PB_STAT_Ready; if (indicate) { percentCSTAT_indication(STATE_MSG_PBOOK, ENTITY_STATUS_Ready); } for (idx = 0; idx < CMD_SRC_MAX; idx++) { pPHBCmdPrm = &cmhPrm[idx].phbCmdPrm; if (pPHBCmdPrm->curCmd EQ AT_CMD_CPBW) { pPHBCmdPrm->curCmd = AT_CMD_NONE; R_AT (RAT_OK, (T_ACI_CMD_SRC)idx) (AT_CMD_CPBW); break; } } break; } case ( PHB_WRITE_FAIL ): { simShrdPrm.pb_stat = PB_STAT_Ready; if (indicate) { percentCSTAT_indication(STATE_MSG_PBOOK, ENTITY_STATUS_Ready); } for (idx = 0; idx < CMD_SRC_MAX; idx++) { pPHBCmdPrm = &cmhPrm[idx].phbCmdPrm; if (pPHBCmdPrm->curCmd EQ AT_CMD_CPBW) { pPHBCmdPrm->curCmd = AT_CMD_NONE; R_AT( RAT_CME, (T_ACI_CMD_SRC)idx)( AT_CMD_CPBW, cmeError ); break; } } break; } case ( PHB_BUSY ): { #ifdef TI_PS_FFS_PHB simShrdPrm.pb_stat = PB_STAT_Busy; if (indicate) { percentCSTAT_indication(STATE_MSG_PBOOK, ENTITY_STATUS_NotReady); } break; #endif } /*lint -fallthrough */ case ( PHB_UNKNOWN ): { simShrdPrm.pb_stat = PB_STAT_Blocked; if (indicate) { percentCSTAT_indication(STATE_MSG_PBOOK, ENTITY_STATUS_NotReady); } break; } default: { TRACE_EVENT("FATAL ERROR in cmhPHB_StatIndication"); simShrdPrm.pb_stat = PB_STAT_Blocked; return -1; } } #if defined _CONC_TESTING_ AND defined TI_PS_FF_CONC_SMS if (simShrdPrm.pb_stat EQ PB_STAT_Ready) { concSMS_delAllIncompleteMsg(); } #endif for( idx = 0; idx < CMD_SRC_MAX; idx++ ) { R_AT( RAT_PHB_STATUS, (T_ACI_CMD_SRC)idx )( simShrdPrm.pb_stat ); } return 0; } /*==== EOF ========================================================*/