FreeCalypso > hg > fc-tourmaline
view src/g23m-aci/aci/line_edit_intern.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : | Modul : line edit +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This modul ... +----------------------------------------------------------------------------- */ #ifndef LINE_EDIT_INTERN_H #define LINE_EDIT_INTERN_H #define WS 0x20 #define SLASH '/' typedef struct S_LEDIT_ATCMD_M { T_LEDIT_ATCMD *cmd; struct S_LEDIT_ATCMD_M *next; } T_LEDIT_ATCMD_M; typedef struct S_LEDIT_INTERN { UBYTE src_id; USHORT len; BOOL isStr; /* flag for start and end of "....." */ USHORT copyIter; /* copy iterator from src to cmd buffer */ USHORT srcBufIter; /* iterator over the srcBuffer */ USHORT srcBufIterE; /* from here all chars to echo */ const UBYTE *srcBuffer; char *lineBuffer; /* cmds without "AT" and removed WS,BS,... */ USHORT lineBufIter; char *origBuffer; /* cmds without "AT", removed WS,BS,... - NOT converted to upper case */ USHORT origBufIter; char *execBuffer; /* the current command(s) as well as */ USHORT execBufIter; /* for AT/ the copy of the last cmd line */ char *smsBuffer; /* text of a SMS */ BOOL txtChunk; /* received a chunk of text only */ T_LEDIT_ATCMD_M *cmdm; /* */ UBYTE cmdIndex; /* */ UBYTE cmdGetIter; /* needed in ledit_get_next() */ T_LEDIT_RSLT (*state) (struct S_LEDIT_INTERN *atiInt); /* state machine function pointer */ T_LEDIT lineHabit; /* the behaviour of the line */ T_LEDIT_ERR err; } T_LEDIT_INTERN; typedef struct S_LEDIT_SRC_MAINTAIN { T_LEDIT_INTERN *leditInt; struct S_LEDIT_SRC_MAINTAIN *next; } T_LEDIT_SRC_MAINTAIN; /* moved from line_edit.h to avoid multiple memory allocation in different modules */ static const T_LEDIT_ERR ledit_err[] = { {"out of memory", LEDIT_ERR_NoMemory}, {"no maintenance for src_id", LEDIT_ERR_NoMaintenance}, {"no valid command", LEDIT_ERR_NoValidCommand}, {"last cmd line is pending", LEDIT_ERR_LastCmdPending}, {"unkown error", LEDIT_ERR_Unknown} }; #endif