FreeCalypso > hg > fc-tourmaline
view src/g23m-aci/aci/sap_dti.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : ... | Modul : sap_dti.h +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : This modul ... +----------------------------------------------------------------------------- */ #define ACI_CONNECT_DTI 0x00 #define ACI_DISCONNECT_DTI 0x01 #define NOT_READY 0x00 #define READY 0x01 typedef struct { BOOL isDtiConnected; UBYTE dtxState; } T_ACI_SRC_DTI_PARAMS; /* process functions for DTI Lib */ EXTERN void dti_lib_dti_dti_connect_cnf ( T_DTI2_CONNECT_CNF *dti_connect_cnf ); EXTERN void dti_lib_dti_dti_connect_ind ( T_DTI2_CONNECT_IND *dti_connect_ind ); EXTERN void dti_lib_dti_dti_disconnect_ind ( T_DTI2_DISCONNECT_IND *dti_disconnect_ind ); EXTERN void dti_lib_dti_dti_data_ind ( T_DTI2_DATA_IND *dti_data_ind ); EXTERN void dti_lib_dti_dti_ready_ind ( T_DTI2_READY_IND *dti_ready_ind ); #ifdef _SIMULATION_ EXTERN const void dti_lib_dti_dti_data_test_ind ( T_DTI2_DATA_TEST_IND *dti_data_test_ind ); #endif EXTERN void psaACI_Init(); EXTERN void aci_pei_sig_callback(U8 instance, U8 interfac, U8 channel, U8 reason, T_DTI2_DATA_IND* dti_data_ind); /* function for "ACI PSA" */ EXTERN BOOL psaACI_Dti_Req (T_DTI_CONN_LINK_ID link_id, T_DTI_ENTITY_ID peer_ent_id, UBYTE dti_conn); #ifdef DTI_CNTRL_MNG_C T_ACI_SRC_DTI_PARAMS aci_src_dti_params[CMD_SRC_MAX]; DTI_HANDLE aci_hDTI; #else EXTERN T_ACI_SRC_DTI_PARAMS aci_src_dti_params[]; EXTERN DTI_HANDLE aci_hDTI; #endif /* OLD DTI Manager stuff */ #define ACI_DTI_DN_CHANNEL 0 #define DTI_MNG_ID_NOTPRESENT 0