FreeCalypso > hg > fc-tourmaline
view src/g23m-aci/aci/wap_aci.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 (2021-04-26) |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM-F&D (8411) | Modul : WAP +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions for the WAP module +----------------------------------------------------------------------------- */ #ifndef WAP_ACI_H #define WAP_ACI_H /*==== TYPES ======================================================*/ typedef enum { Wap_Not_Init = -1 , #ifdef FF_GPF_TCPIP TCPIP_Initialization, TCPIP_Initialized, TCPIP_Activation , TCPIP_Activated , #endif /*FF_GPF_TCPIP*/ UDPA_Activation , UDPA_Activated , IPA_Activation , IPA_Activated , IPA_Configuration , IPA_Configurated , UDPA_Configuration , UDPA_Configurated , #ifdef FF_GPF_TCPIP TCPIP_Configuration , TCPIP_Configurated , #endif /*FF_GPF_TCPIP*/ IPA_Deconfiguration, IPA_Deconfigurated, UDPA_Deconfiguration, UPDA_Deconfigurated, #ifdef FF_GPF_TCPIP TCPIP_Deconfiguration, TCPIP_Deconfigurated, TCPIP_Deactivation, TCPIP_Deactivated, #endif /*FF_GPF_TCPIP*/ UDPA_Deactivation, UDPA_Deactivated, IPA_Deactivation, IPA_Deactivated } T_ACI_WAP_STATES; /* * Indicate is IP connected or disconnected */ typedef enum { IPA_CONN, IPA_DSC } T_ACI_IPA_DIRC; /*==== EXPORT =====================================================*/ /* * Prototypes for IP and UDP. */ EXTERN void psaIPA_Config ( ULONG ip, USHORT max_trans_unit, T_ACI_IPA_DIRC dirc ); EXTERN void psaUDPA_Config ( UBYTE dirc ); EXTERN T_ACI_RETURN cmhIPA_Configurated ( void ); EXTERN T_ACI_RETURN cmhIPA_Deconfigurated ( void ); EXTERN T_ACI_RETURN cmhUDPA_Activate ( T_ACI_CMD_SRC srcId, SHORT cId ); EXTERN T_ACI_RETURN cmhUDPA_Configurated ( void ); EXTERN T_ACI_RETURN cmhUDPA_Deconfigurated ( void ); EXTERN T_ACI_RETURN cmhUDPA_Deactivate ( UBYTE src_id ); EXTERN T_ACI_RETURN cmhTCPIP_Activate ( T_ACI_CMD_SRC srcId, SHORT cId ); EXTERN T_ACI_RETURN cmhTCPIP_Configurated ( void ); EXTERN T_ACI_RETURN cmhTCPIP_Deconfigurated ( void ); EXTERN T_ACI_RETURN cmhTCPIP_Deactivate ( UBYTE src_id ); EXTERN void psaIPA_Dti_Req(ULONG dti_id, UBYTE peer_to_connect_to, UBYTE dti_conn); EXTERN void psaUDPA_Dti_Req(ULONG dti_id, UBYTE peer_to_connect_to, UBYTE dti_conn); EXTERN void psaWAP_Dti_Req(ULONG dti_id, UBYTE peer_to_connect_to, UBYTE dti_conn); /* * Variables for WAP, state, id and CALL */ #ifdef PSA_PPPP_C GLOBAL T_ACI_WAP_STATES wap_state = Wap_Not_Init; GLOBAL SHORT wapId = NO_ENTRY; GLOBAL BOOL Wap_Call = FALSE; GLOBAL UBYTE wap_dti_id = DTI_DTI_ID_NOTPRESENT; GLOBAL ULONG peer_link_id = DTI_LINK_ID_NOTPRESENT; GLOBAL ULONG prot_link_id = DTI_LINK_ID_NOTPRESENT; GLOBAL UBYTE peer_entity_id = DTI_ENTITY_MAX; GLOBAL UBYTE prot_entity_id = DTI_ENTITY_MAX; #else EXTERN T_ACI_WAP_STATES wap_state; EXTERN SHORT wapId; EXTERN BOOL Wap_Call; EXTERN UBYTE wap_dti_id; EXTERN ULONG peer_link_id; EXTERN ULONG prot_link_id; EXTERN UBYTE peer_entity_id; EXTERN UBYTE prot_entity_id; #endif /* of #ifdef CMH_UDPAS_C */ #endif /* of #ifndef WAP_ACI_H */