FreeCalypso > hg > fc-tourmaline

view src/g23m-fad/tcpip/include/rv_trace.h @ 220:0ed36de51973

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000 (2021-04-26)
parents fa8dc04885d8
children
line wrap: on
line source
/*************************************************************************************
 *                                               *
 *  Name        rv_trace.h                                   *
 *                                               *
 *  Function    this file contains trace definitions for basic layers             *
 *                                               *
 *  Date        Modification                                                         *
 *  ------------------------                                 *
 *  10/12/00   - Create Cristian Livadiotti - c-livadiotti@ti.com               *
 *                                               *
 *                                               *
 * (C) Copyright 1999 by Texas Instruments Incorporated, All Rights Reserved         *
 *                                                                                   *
 * --------------------------------------------------------------------------------- *
 *                                                                                   *
 *   History:                                                                        *
 *                                                                                   *
 *   10/18/2001 - Updated for R2D by Christophe Favergeon                         *
 *                                                                                   *
 *************************************************************************************/

#ifndef _RV_TRACE_H_
#define _RV_TRACE_H_

/* Define trace levels.                                                          */
#define RV_TRACE_LEVEL_ERROR (1) /* Error condition trace messages. */
                      /* Used when an unrecoverable error is found */
#define RV_TRACE_LEVEL_WARNING (2) /* Warning condition trace messages. */
                      /* Used when an error is found but is handled properly by the code*/
#define RV_TRACE_LEVEL_DEBUG_HIGH (3) /* Debug messages (high debugging). */
                                            /* high = important debug message */
#define RV_TRACE_LEVEL_DEBUG_MEDIUM (4) /* Debug messages. */
#define RV_TRACE_LEVEL_DEBUG_LOW (5) /* Debug messages (low debugging). */
                                            /* low = not important debug message */

/* temporary definition of this old flag for backward compatibility */
#define TRACE_RVTEST (0x001E0004)

#endif /* _RV_GENERAL_H_*/