FreeCalypso > hg > fc-tourmaline
view src/g23m-fad/tcpip/rnet/rnet_dti_info.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +------------------------------------------------------------------------------ | File: rnet_dti_info.h +------------------------------------------------------------------------------ | Copyright 2003 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : DTI point-to-point network interface for RNET_RT, | Custom information +----------------------------------------------------------------------------- */ /* derived from... */ /** * @file rnet_atp_info.h * * ATP point-to-point network interface for RNET_RT * Custom information * * @author Regis Feneon * @version 0.1 */ /* * $Id: rnet_atp_info.h,v 1.1 2002/09/06 08:39:52 rf Exp $ * $Name: $ * * History: * * Date Author Modification * -------------------------------------------------- * 6/9/2002 Regis Feneon Create * */ #include "rnet_cfg.h" #ifdef RNET_CFG_REAL_TRANSPORT #ifndef __RNET_RT_DTI_INFO_H_ #define __RNET_RT_DTI_INFO_H_ #include "rnet_ip_addr.h" #include "dcfg_api.h" #define RNET_RT_DTI_MTU 1500 /* * DTI custom information */ typedef struct { T_RNET_IP_ADDR local_addr ; /* Local (MS) IP address. */ T_RNET_IP_ADDR dest_addr ; /* Destination (GGSN) IP address, this is also * the default router. */ UINT16 mtu ; /* Maximum transmission unit. */ T_RNET_IP_ADDR dns1 ; /* Primary DNS server address. */ T_RNET_IP_ADDR dns2 ; /* Secondary DNS server address. */ T_APPLI_USER IPU_id ; /* Identity of the user of the channel. */ } T_RNET_RT_DTI_CUSTOM_INFO ; #endif /* __RNET_RT_DTI_INFO_H_ */ #endif /* RNET_CFG_REAL_TRANSPORT */ /* EOF */