FreeCalypso > hg > fc-tourmaline
view src/g23m-fad/tcpip/rnet/rnet_rt/rnet_rt_env.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | fa8dc04885d8 |
| children |
line wrap: on
line source
/** * @file rnet_rt_env.h * * Declarations of the Riviera Generic Functions * * @author Jose Yp-Tcha (j-yp-tcha@ti.com) * @version 0.1 */ /* * History: * * Date Author Modification * ------------------------------------------------------------------- * 3/19/2002 Jose Yp-Tcha (j-yp-tcha@ti.com) Create. * * (C) Copyright 2002 by TI, All Rights Reserved */ #include "rnet_cfg.h" #ifdef RNET_CFG_REAL_TRANSPORT #ifndef __RNET_RT_ENV_H_ #define __RNET_RT_ENV_H_ #include "rvm_gen.h" /* Generic RVM types and functions. */ #include "rvf_pool_size.h" /** * @name Mem bank * * Memory bank size and watermark. * Size and watermark are not defined statically,but dynamically */ /** length of pool of network buffers */ #define RNET_RT_BUFPOOL_SIZE RVF_RNET_RT_MB1_BUFPOOL_SIZE /** part of memory pool reserved for messages */ #define RNET_RT_MSGPOOL_SIZE RVF_RNET_RT_MB1_MSGPOOL_SIZE /** stack size of RNET task */ #define RNET_RT_STACK_SIZE RVF_RNET_RT_STACK_SIZE #define RNET_RT_MB_PRIM_SIZE RVF_RNET_RT_POOL_SIZE #define RNET_RT_MB_PRIM_WATERMARK ( RVF_RNET_RT_POOL_SIZE - 128 ) /* Timer index for TCPIP Entity */ #define RNET_RT_NGIP_TIMER 0 /** * @name Generic functions * * Generic functions declarations needed for a Type 4 SWE * (Group Member SWE). */ /*@{*/ T_RVM_RETURN rnet_rt_get_info (T_RVM_INFO_SWE *info_swe); T_RVM_RETURN rnet_rt_set_info ( T_RVF_ADDR_ID addr_id, T_RV_RETURN_PATH return_path[], T_RVF_MB_ID bk_id_table[], T_RVM_CB_FUNC call_back_error_ft); T_RVM_RETURN rnet_rt_init (void); T_RVM_RETURN rnet_rt_start (void); T_RVM_RETURN rnet_rt_handle_message (T_RV_HDR * msg); T_RVM_RETURN rnet_rt_handle_timer (T_RV_HDR * msg); T_RVM_RETURN rnet_rt_stop (void); T_RVM_RETURN rnet_rt_kill (void); /*@}*/ #endif /*__RNET_RT_ENV_H_*/ #endif /* ifdef RNET_CFG_REAL_TRANSPORT */