FreeCalypso > hg > fc-tourmaline
view src/g23m-fad/tcpip/rnet/rnet_trace.c @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/** * @file rnet_trace.c * * Riviera NET. * * PC trace functions. Only under Riviera Tool. * * @author Vincent Oberle (v-oberle@ti.com) * @version 0.1 */ /* * History: * * Date Author Modification * -------------------------------------------------- * 01/30/2002 Vincent Oberle Create * * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved */ #include "rnet_trace_i.h" #ifdef RNET_TRACE_RET /** * Traces the return value of RNET API functions. */ void rnet_trace_ret (T_RNET_RET ret) { switch (ret) { case RNET_OK: //RNET_TRACE_LOW("RNET: OK"); break; case RNET_MEMORY_ERR: RNET_TRACE_LOW("RNET: MEMORY_ERR"); break; case RNET_INVALID_PARAMETER: RNET_TRACE_LOW("RNET: INVALID_PARAMETER"); break; case RNET_NOT_SUPPORTED: RNET_TRACE_LOW("RNET: NOT_SUPPORTED"); break; case RNET_NOT_READY: RNET_TRACE_LOW("RNET: NOT_READY"); break; case RNET_INTERNAL_ERR: RNET_TRACE_LOW("RNET: INTERNAL_ERR"); break; case RNET_IN_USE: RNET_TRACE_LOW("RNET: IN_USE"); break; case RNET_NOT_INITIALIZED: RNET_TRACE_LOW("RNET: NOT_INITIALIZED"); break; case RNET_NET_UNREACHABLE: RNET_TRACE_LOW("RNET: NET_UNREACHABLE"); break; case RNET_TIMEOUT: RNET_TRACE_LOW("RNET: TIMEOUT"); break; case RNET_CONN_REFUSED: RNET_TRACE_LOW("RNET: CONN_REFUSED"); break; case RNET_CONN_RESET: RNET_TRACE_LOW("RNET: CONN_RESET"); break; case RNET_CONN_ABORTED: RNET_TRACE_LOW("RNET: CONN_ABORTED"); break; case RNET_CONN_CLOSED: RNET_TRACE_LOW("RNET: CONN_CLOSED"); break; case RNET_MSG_SIZE: RNET_TRACE_LOW("RNET: MSG_SIZE"); break; case RNET_PARTIAL_SENT: RNET_TRACE_LOW("RNET: PARTIAL_SENT"); break; case RNET_HOST_NOT_FOUND: RNET_TRACE_LOW("RNET: HOST_NOT_FOUND"); break; default: RNET_TRACE_MEDIUM_PARAM("RNET: Unknown return value: ", ret); } } #endif