FreeCalypso > hg > fc-tourmaline

view src/g23m-fad/tcpip/rnet/rnet_trace_i.h @ 220:0ed36de51973

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/**
 * @file  rnet_trace_i.h
 *
 * Riviera NET - Internal file.
 *
 * RNET trace macros.
 *
 * @author  Vincent Oberle (v-oberle@ti.com)
 * @version 0.1
 */

/*
 * History:
 *
 *   Date         Author        Modification
 *  --------------------------------------------------
 *  01/25/2002  Vincent Oberle    Create
 *
 * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved
 */

#ifndef __RNET_TRACE_I_H_
#define __RNET_TRACE_I_H_

#include "rv_general.h"
#include "rvf_api.h"
#include "rvm_use_id_list.h"

#include "rnet_api.h"

/** Traces the return value of RNET API functions or not. */
#define RNET_TRACE_RET

#define RNET_TRACE(string, level) \
  rvf_send_trace(string, sizeof(string) - 1, NULL_PARAM, level, RNET_USE_ID);

#define RNET_TRACE_PARAM(string, param, level) \
  rvf_send_trace(string, sizeof(string) - 1, param, level, RNET_USE_ID);

#define RNET_TRACE_ERROR(string) \
  rvf_send_trace(string, sizeof(string) - 1, NULL_PARAM, \
          RV_TRACE_LEVEL_ERROR, RNET_USE_ID);

#define RNET_TRACE_ERROR_PARAM(string, param) \
  rvf_send_trace(string, sizeof(string) - 1, param, \
          RV_TRACE_LEVEL_ERROR, RNET_USE_ID);

#define RNET_TRACE_WARNING(string) \
  rvf_send_trace(string, sizeof(string) - 1, NULL_PARAM, \
          RV_TRACE_LEVEL_WARNING, RNET_USE_ID);

#define RNET_TRACE_WARNING_PARAM(string, param) \
  rvf_send_trace(string, sizeof(string) - 1, param, \
          RV_TRACE_LEVEL_WARNING, RNET_USE_ID);

#define RNET_TRACE_HIGH(string) \
  rvf_send_trace(string, sizeof(string) - 1, NULL_PARAM, \
          RV_TRACE_LEVEL_DEBUG_HIGH, RNET_USE_ID);

#define RNET_TRACE_HIGH_PARAM(string, param) \
  rvf_send_trace(string, sizeof(string) - 1, param, \
          RV_TRACE_LEVEL_DEBUG_HIGH, RNET_USE_ID);

#define RNET_TRACE_MEDIUM(string) \
  rvf_send_trace(string, sizeof(string) - 1, NULL_PARAM, \
          RV_TRACE_LEVEL_DEBUG_MEDIUM, RNET_USE_ID);

#define RNET_TRACE_MEDIUM_PARAM(string, param) \
  rvf_send_trace(string, sizeof(string) - 1, param, \
          RV_TRACE_LEVEL_DEBUG_MEDIUM, RNET_USE_ID);

#define RNET_TRACE_LOW(string) \
  rvf_send_trace(string, sizeof(string) - 1, NULL_PARAM, \
          RV_TRACE_LEVEL_DEBUG_LOW, RNET_USE_ID);

#define RNET_TRACE_LOW_PARAM(string, param) \
  rvf_send_trace(string, sizeof(string) - 1, param, \
          RV_TRACE_LEVEL_DEBUG_LOW, RNET_USE_ID);

#ifdef RNET_TRACE_RET
void rnet_trace_ret (T_RNET_RET ret);
#else
#define rnet_trace_ret(ret)
#endif

#endif /* __RNET_TRACE_I_H_ */