FreeCalypso > hg > fc-tourmaline
view src/g23m-gprs/gmm/gmm_f.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GPRS (8441) | Modul : gmm_f.h +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions for gmm_f.c +----------------------------------------------------------------------------- */ #ifndef GMM_F_H #define GMM_F_H /* * gmm data debug print mask * select type of information for debug print */ enum { GMM_DEBUG_PRINT_MASK_FULL = 0x0fff, /* */ // GMM_DEBUG_PRINT_MASK_COMMON = 0x0001, /* 00000000 00000001 */ GMM_DEBUG_PRINT_MASK_TIMER = 0x0002, /* 00000000 00000010 */ GMM_DEBUG_PRINT_MASK_STATE = 0x0004, /* 00000000 00000100 */ GMM_DEBUG_PRINT_MASK_TLLI = 0x0008, /* 00000000 00001000 */ GMM_DEBUG_PRINT_MASK_IMSI = 0x0010, /* 00000000 00010000 */ GMM_DEBUG_PRINT_MASK_PTMSI = 0x0020, /* 00000000 00100000 */ GMM_DEBUG_PRINT_MASK_CID = 0x0040, /* 00000000 01000000 */ GMM_DEBUG_PRINT_MASK_RAI = 0x0080, /* 00000000 10000000 */ // GMM_DEBUG_PRINT_MASK_KERN = 0x0100, /* 00000001 00000000 */ GMM_DEBUG_PRINT_MASK_KERN_ATTACH = 0x0200, /* 00000010 00000000 */ GMM_DEBUG_PRINT_MASK_END, GMM_DEBUG_PRINT_MASK_MAX = (GMM_DEBUG_PRINT_MASK_END - 1) }; typedef U32 GMM_DEBUG_PRINT_MASK_ENUM_TYPE; EXTERN void gmm_debug_do_print_gmm_data(GMM_DEBUG_PRINT_MASK_ENUM_TYPE print_mask); #ifdef WIN32 #define GMM_TRACE_GMM_DATA(m) gmm_debug_do_print_gmm_data(m) #else #define GMM_TRACE_GMM_DATA(m) #endif EXTERN ULONG gmm_get_tlli ( T_TLLI_TYPE tlli_type ); EXTERN void gmm_set_current_tlli ( T_TLLI_TYPE tlli_type ); #endif /* GMM_F_H */