FreeCalypso > hg > fc-tourmaline
view src/g23m-gprs/grr/grr_cpapf.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GPRS (8441) | Modul : GRR +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions for service CPAP. +----------------------------------------------------------------------------- */ #ifndef GRR_CPAPF_H #define GRR_CPAPF_H typedef enum { E_PDCH_ASSIGN_IGNORE, /* no effect on current tbf */ E_PDCH_ASSIGN_ERROR, E_PDCH_ASSIGN_UL, E_PDCH_ASSIGN_SB, E_PDCH_ASSIGN_DL, E_PDCH_ASSIGN_ASSIGN /* valid message send mphp_assign_req */ } T_EVAL_PDCH_ASSIGN; EXTERN void cpap_init ( void ); EXTERN T_EVAL_IA cpap_eval_ia ( void ); EXTERN T_EVAL_IA_DL cpap_eval_ia_dl ( void ); EXTERN T_EVAL_PDCH_ASSIGN cpap_eval_pdch_assignment ( void ); EXTERN void cpap_build_gprs_data_request (T_RRGRR_GPRS_DATA_REQ *rrgrr_gprs_data_req); EXTERN void cpap_send_ass_fail (UBYTE cause); EXTERN void cpap_send_assign_req_pdch (T_TBF_TYPE tbf_type_i); EXTERN BOOL cpap_send_assign_req_ia ( T_TBF_TYPE tbf_type_i ); EXTERN UBYTE cpap_send_resource_request_ia ( void ); EXTERN UBYTE cpap_send_single_block_without_tbf ( void ); EXTERN void cpap_set_da_assignment_ia (T_MPHP_ASSIGNMENT_REQ *ptr2prim); EXTERN UBYTE cpap_set_fa_assignment_ia (T_MPHP_ASSIGNMENT_REQ *ptr2prim); EXTERN void cpap_set_dl_assignment_ia (T_MPHP_ASSIGNMENT_REQ *ptr2prim); EXTERN UBYTE cpap_send_receive_normal_burst ( void ); EXTERN void cpap_join_tma_messages ( void ); EXTERN void cpap_store_ia_message ( void ); EXTERN void cpap_malloc_ia ( void ); EXTERN void cpap_mfree_ia ( BOOL restore_data ); #endif /* !GRR_CPAPF_H */