FreeCalypso > hg > fc-tourmaline
view src/g23m-gprs/grr/grr_psis.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GPRS (8441) | Modul : GRR +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions for service PSI. +----------------------------------------------------------------------------- */ #ifndef GRR_PSIS_H #define GRR_PSIS_H EXTERN void sig_ctrl_psi_si13_received ( T_RRGRR_GPRS_SI13_IND *rrgrr_si13_ind, BOOL ba_bcch_changed ); EXTERN void sig_ctrl_psi_pim ( void ); EXTERN void sig_ctrl_psi_pam ( void ); EXTERN void sig_ctrl_psi_ptm ( void ); EXTERN void sig_ctrl_psi_suspend ( void ); EXTERN void sig_ctrl_psi_resumpt ( void ); EXTERN void sig_ctrl_psi_resumpt_cc ( void ); EXTERN void sig_ctrl_psi_stop ( void ); EXTERN void sig_ctrl_psi_sync_ok (void); EXTERN void sig_ctrl_psi_read_full_psi_in_new_cell(void); EXTERN void sig_ctrl_psi_rel_state(T_RELEASE_STATE rel_state); EXTERN void sig_ctrl_psi_access_disabled ( T_PSI_DISABLE_CAUSE dc ); /* GFP PTM*/ EXTERN void sig_gfp_psi_1_ptm ( void ); EXTERN void sig_gfp_psi_2_ptm ( void ); EXTERN void sig_gfp_psi_3_ptm ( void ); EXTERN void sig_gfp_psi_3_bis_ptm ( void ); #if defined (REL99) AND defined (TI_PS_FF_EMR) EXTERN void sig_gfp_psi_3_ter_ptm ( void ); #endif EXTERN void sig_gfp_psi_4_ptm ( void ); EXTERN void sig_gfp_psi_13_ptm ( void ); #ifdef REL99 EXTERN void sig_gfp_psi_8_ptm ( void ); #endif /* GFP*/ EXTERN void sig_gfp_psi_1 ( void ) ; EXTERN void sig_gfp_psi_2 ( UBYTE rel_pos_i) ; EXTERN void sig_gfp_psi_3 ( UBYTE rel_pos_i) ; EXTERN void sig_gfp_psi_3_bis ( UBYTE rel_pos_i ); #if defined (REL99) AND defined (TI_PS_FF_EMR) EXTERN void sig_gfp_psi_3_ter ( UBYTE rel_pos_i ); #endif EXTERN void sig_gfp_psi_4 ( UBYTE rel_pos_i ) ; EXTERN void sig_gfp_psi_5 ( UBYTE rel_pos_i ) ; EXTERN void sig_gfp_psi_prach ( void ) ; EXTERN void sig_gfp_psi_scell_pbcch_stop_con ( T_MPHP_SCELL_PBCCH_STOP_CON *mphp_scell_pbcch_stop_con) ; EXTERN void sig_gfp_psi_ncell_pbcch_ind ( T_MPHP_NCELL_PBCCH_IND *mphp_ncell_pbcch_ind) ; EXTERN void sig_gfp_psi_save_persistence_level ( T_pers_lev * ptr2persistence_level_i ); /*MODIF*/ #ifdef REL99 EXTERN void sig_gfp_psi_8 ( UBYTE rel_pos_i) ; #endif #endif /* !GRR_PSIS_H */