FreeCalypso > hg > fc-tourmaline
view src/gpf/inc/typedefs.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 4e78acac3d88 |
children |
line wrap: on
line source
/* +------------------------------------------------------------------------------ | File: typedefs.h +------------------------------------------------------------------------------ | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Standard definitions. +----------------------------------------------------------------------------- */ #ifndef __TYPEDEFS_H__ #define __TYPEDEFS_H__ /*===== Include operating system specific type definitions ========*/ #ifdef _VXWORKS_ #include <vxWorks.h> #endif #ifdef PSOS #include <stdio.h> #endif /*==== CONSTANTS ==================================================*/ #ifndef __INCvxWorksh #define IMPORT EXTERN #endif #ifndef __cplusplus #define EXTERN extern #else #define EXTERN extern "C" #endif #define LOCAL static #define GLOBAL #define EXPORT GLOBAL /*lint -e723 supress Info -- Suspicious use of = */ #define EQ == /*lint +e723 */ #define NEQ != #define AND && #define OR || #define XOR(A,B) ((!(A) AND (B)) OR ((A) AND !(B))) #ifndef FALSE #define FALSE 0 #endif #ifndef TRUE #define TRUE 1 #endif #ifndef NULL #define NULL 0 #endif /*==== TYPES ======================================================*/ #ifndef STDDEFS_H typedef unsigned char U8; typedef signed char S8; typedef unsigned short U16; typedef signed short S16; typedef unsigned long U32; typedef signed long S32; typedef U32 MEMHANDLE; /* * UINT16 added for TI include files, to be removed ASAP */ #ifndef GENERAL_H /* rivera include definitions are as ours */ #ifndef __INCvxTypesOldh #if !defined NUCLEUS || !defined PLUS_VERSION_COMP /* UINT16 is already defined in the nucleus.h for the arm9 */ typedef unsigned short UINT16; #endif #endif typedef unsigned char UBYTE; typedef short SHORT; typedef UBYTE BYTE; #if !defined (NUCLEUS) typedef char CHAR; #endif /* the following construction assumes that we are on I86 using Windows. It is introduced to avoid using WIN32 in GPF but keeping the compatibility with the protocol stack */ #if defined WIN32 || defined _WIN32 typedef int BOOL; #else #ifdef _VXWORKS_ #ifndef __INCvxTypesOldh typedef int BOOL; #endif #else typedef UBYTE BOOL; #endif #endif #ifndef _TYPES_H #ifndef __INCvxTypesOldh typedef unsigned char UCHAR; typedef unsigned short USHORT; typedef unsigned long ULONG; typedef unsigned int UINT; #endif #endif #endif /* rivera include definitions are as ours */ typedef long LONG; typedef unsigned long T_VOID_STRUCT; typedef unsigned long T_ENUM; #endif /*==== EXPORT =====================================================*/ #define MAXIMUM(A,B) (((A)>(B))?(A):(B)) #define MINIMUM(A,B) (((A)<(B))?(A):(B)) /* * NOTE: This is necessary until all occurences of Sprintf() in the * protocol stack (GSM and GPRS) have been replaced with sprintf(). */ #define Sprintf sprintf /* * NOTE: The following macros redefine the predefined macros of * the TMS470 compiler. This is usefull for creating binary * equivalent object files. These files can be used for the * comparison of to builds e.g. BUSYB and g23.pl. * * This approach may not work with other compilers. */ #define TMS470_CDS "__NO_DATE__" #define TMS470_CTS "__NO_TIME__" #define TMS470_CFS "__NO_FILE__" #endif