FreeCalypso > hg > fc-tourmaline
view src/ui/atb/ATBDisplay.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 67bfe9f274f6 |
children |
line wrap: on
line source
/******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: MMI $File: ATBDisplay.h $Revision: 1.0 $Author: Condat(UK) $Date: 22/02/01 ******************************************************************************** Description: ******************************************************************************** $History: ATBDisplay.h 15/03/02 Original Condat(UK) BMI version. Jan 16, 2006 DR: OMAPS00061460 - Shashi Shekar B.S. Description: SAT Icon support Solution : Added definitions for height & width of the title icon. $End *******************************************************************************/ #ifndef ATB_DISPLAY_H #define ATB_DISPLAY_H // Shashi Shekar B.S., a0876501, 16-Jan-2006, OMAPS00061460 #ifdef FF_MMI_SAT_ICON #define TITLE_ICON_WIDTH 10 #define TITLE_ICON_HEIGHT 16 extern const unsigned char SATIconQuestionMark[]; #endif /* * T_DS_TEXTFORMAT * Data type to contain formatting attributes */ typedef struct { UBYTE attr; /* Standard attributes */ BOOL highlight; /* TRUE if highlighting is on */ } T_DS_TEXTFORMAT; #define WHOLE_STRING 0xFFFF // Used to indicate that the whole string is to be used for a particular function /* Cursor types */ typedef enum { DS_CURSOR_NONE = 0, DS_CURSOR_BAR, DS_CURSOR_UNDERLINE, DS_CURSOR_BLOCK } T_DS_CURSOR; /* Alignments */ typedef enum { DS_ALIGN_LEFT = 0, DS_ALIGN_RIGHT = 1, DS_ALIGN_CENTRE = 2 } T_DS_ALIGN; /* Local function prototypes */ void ATB_display_Cursor (T_ATB_TEXT *text, USHORT textIndex, UBYTE type, SHORT x, SHORT y, USHORT width, USHORT height); void ATB_display_Text(SHORT x, SHORT y, T_DS_TEXTFORMAT *format, T_ATB_TEXT *text); void ATB_display_SetFormatAttr(T_DS_TEXTFORMAT *format, USHORT attr, BOOL highlight); void ATB_display_ClearFormat(T_DS_TEXTFORMAT *format); void ATB_display_CopyFormat(T_DS_TEXTFORMAT *dest, T_DS_TEXTFORMAT *src); int ATB_display_GetCharWidth (USHORT character, T_DS_TEXTFORMAT *format); int ATB_display_GetMaxCharWidth (T_DS_TEXTFORMAT *format); int ATB_display_GetCharHeight (USHORT character, T_DS_TEXTFORMAT *format); USHORT ATB_display_StringWidth(T_ATB_TEXT *text, T_DS_TEXTFORMAT *format); USHORT ATB_display_StringHeight(T_ATB_TEXT *text, T_DS_TEXTFORMAT *format); #endif