ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.

/*********************************************
 * PB_RECS_PER_FILE
 * 
 * Specifies how many records should be stored in
 * each file on the flash.
 *********************************************/
 
#define PB_RECS_PER_FILE			10

/*********************************************
 * PB_xxx_UPPER_LIMIT
 * 
 * The absolute maximum size of various aspects
 * of the records stored on the file system.  Used
 * to keep values read in from file within a 
 * sensible range.
 *********************************************/
 
#define PB_RECORDS_UPPER_LIMIT		500
#define PB_ALPHATAG_UPPER_LIMIT		500
#define PB_NUMBER_UPPER_LIMIT		500
#define PB_EXT_UPPER_LIMIT			500


/**********************************************
 * T_PB_FSDATA	
 * 
 * Internal information for FS
 *********************************************/
 
typedef struct
{
	SHORT records_max;
	SHORT alpha_max;
	SHORT number_max;
	SHORT ext_max;
	SHORT record_size;
	T_FFS_FD info_file;
	SHORT fileID;
	T_FFS_FD file;
}
T_PB_FSDATA;

/**********************************************
 * T_PB_FSINFO
 * 
 * Information about phonebook -
 * e.g. is SIM or FFS selected ?
 *********************************************/
 
typedef struct
{
	UBYTE	type_selected;	/* The current selected phonebook */
	SHORT records_max;
	SHORT alpha_max;
	SHORT number_max;
	SHORT ext_max;
}
T_PB_FSINFO;

/**********************************************
 * LOCAL FUNCTION PROTOTYPES
 *
 *********************************************/
 
void FS_file_GetIndex(SHORT phys_index, SHORT *fileIndex, SHORT *recIndex);
void FS_file_GetName(char *filename, SHORT phonebook_id, SHORT fileIndex);
SHORT FS_file_OpenForRec(SHORT phonebook_id, SHORT phys_index);