FreeCalypso > hg > fc-tourmaline
view src/ui/bmi/mmiEm.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | d61a07309733 |
children |
line wrap: on
line source
#ifndef _MMI_EM_H_ #define MMI_EM_H_ /******************************************************************************* CONDAT (UK) ******************************************************************************** This software product is the property of Condat (UK) Ltd and may not be disclosed to any third party without the express permission of the owner. ******************************************************************************** $Project name: Basic MMI $Project code: BMI (6349) $Module: Engineering mode $File: MmiEm.h $Revision: 1.0 $Author: Condat(UK) $Date: 23/09/02 ******************************************************************************** Description: Handles Engineering mode at MMI level ******************************************************************************** $History: MmiEm.c Apr 24, 2006 ERT: OMAPS00067603 x0043642 Description: Engineering mode Solution: Added new engineering mode function prototypes to satisfy Neptune engineering mode requirements. $End*/ /******************************************************************************* Include files *******************************************************************************/ #include "mfw_mfw.h" #include "mfw_mnu.h" /******************************Function Prototypes*******************************/ void mmi_em_init(void); void mmi_em_exit(void); //#ifdef TI_PS_FF_EM #if defined (TI_PS_FF_EM) || defined (MMI_EM_ENABLED) /*Starts the engineering mode menu*/ void mmi_em_start_eng_mode_menus(T_MFW_HND parent); #endif #ifndef NEPTUNE_BOARD /*Called from menu; begins process to display Mobile Information*/ int Mmi_em_display_mobile_info_data(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display Serving Cell parameters*/ int Mmi_em_display_serving_cell_params(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display Neighbouring Cell parameters*/ int Mmi_em_display_neighbour_cell_params(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display Locationparameters*/ int Mmi_em_display_location_params(MfwMnu* m, MfwMnuItem*i ); /*begins process to display Ciphering, hopping and discontinuous transmission parameters*/ int Mmi_em_display_ciph_hop_DTX_params(MfwMnu* m, MfwMnuItem* i); /*Called from menu; begins process to display GPRS specific parameters*/ int Mmi_em_display_GPRS_params(MfwMnu* m, MfwMnuItem* i); #else /* if NEPTUNE_BOARD */ /*Called from menu; begins process to display Serving Cell parameters*/ int Mmi_em_start(MfwMnu* m, MfwMnuItem* i); #endif /*ifndef NEPTUNE_BOARD */ #endif