FreeCalypso > hg > fc-tourmaline
view src/ui/mfw/mfw_acie.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | 92abb46dc1ba |
children |
line wrap: on
line source
/* +--------------------------------------------------------------------+ | PROJECT: MMI-Framework (8417) $Workfile:: mfw_acie.h $| | $Author:: Es $Revision:: 1 $| | CREATED: 26.10.98 $Modtime:: 2.03.00 15:24 $| | STATE : code | +--------------------------------------------------------------------+ MODULE : MFW_ACIE PURPOSE : This modul contains the definition for ACI external functions. $History:: mfw_acie.h $ * * ***************** Version 7 ***************** * User: Es Date: 2.03.00 Time: 16:04 * Updated in $/GSM/Condat/MS/SRC/MFW * some cleanups * * ***************** Version 6 ***************** * User: Es Date: 8.12.98 Time: 16:53 * Updated in $/GSM/DEV/MS/SRC/MFW * * ***************** Version 5 ***************** * User: Vo Date: 24.11.98 Time: 21:40 * Updated in $/GSM/DEV/MS/SRC/MFW * first successful compilation of MFW * * ***************** Version 4 ***************** * User: Le Date: 11.11.98 Time: 13:35 * Updated in $/GSM/DEV/MS/SRC/MFW * * ***************** Version 3 ***************** * User: Le Date: 10.11.98 Time: 16:07 * Updated in $/GSM/DEV/MS/SRC/MFW * * ***************** Version 2 ***************** * User: Le Date: 10.11.98 Time: 11:08 * Updated in $/GSM/DEV/MS/SRC/MFW * * ***************** Version 1 ***************** * User: Le Date: 27.10.98 Time: 15:58 * Created in $/GSM/DEV/MS/SRC/MFW * first implementation */ #define MAX_ACI_HANDLER 10 typedef BOOL (*T_PRIM_HANDLER)(ULONG, void *); typedef BOOL (*T_CMD_HANDLER)(char *); typedef struct { T_PRIM_HANDLER prim_handler; T_CMD_HANDLER cmd_handler; } T_MFW_ACI_EXT; EXTERN void aci_ext_init(void); EXTERN int aci_create(T_PRIM_HANDLER prim_func, T_CMD_HANDLER cmd_func); EXTERN void aci_delete(int handle); EXTERN BOOL aci_check_primitive(ULONG opc, void * data); EXTERN BOOL aci_check_command(char * cmd); #ifdef BT_INTERFACE EXTERN int pSlotBt; /* primitive handler slot */ #endif