view src/ui/mfw/mfw_band.c @ 220:0ed36de51973

ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents 67bfe9f274f6
children
line wrap: on
line source

/*
+--------------------------------------------------------------------+
| PROJECT: GSM-MFW                   $Workfile:: Mfw_band.c           $|
| $Author:: MC/SH                          $Revision::  1              $|
| STATE  : code                                                       |
+--------------------------------------------------------------------+

   MODULE  : MFW_BAND

   PURPOSE : AT%BAND functionality for MFW


   $History: Mfw_band.c                                              $

*/


#define ENTITY_MFW


#include <string.h>
#include <stdio.h>
#include <stdlib.h>

#include "typedefs.h"
#include "vsi.h"
#include "pei.h"
#include "custom.h"
#include "gsm.h"

#include "prim.h"
#ifndef PCM_2_FFS
#include "pcm.h"
#endif

/* BEGIN ADD: Sumit : Req ID: : 31-Mar-2005*/
#ifndef NEPTUNE_BOARD
/* END ADD: Sumit : Req ID: : 31-Mar-2005*/
#include "ffs/ffs.h"
/* BEGIN ADD: Sumit : Req ID: : 31-Mar-2005*/
#else
#include "ffs.h"
#endif
/* END ADD: Sumit : Req ID: : 31-Mar-2005*/


/* SPR#1470 - SH - these includes are now outside of
 * FAX_AND_DATA switch */
#include "message.h"
#include "prim.h"
#include "aci_cmh.h"

#if defined (FAX_AND_DATA)
/*#include "message.h"
#include "prim.h"
#include "aci_cmh.h"  SPR#1470 - SH */
#include "aci_fd.h"
#endif

#ifdef GPRS
#include "gprs.h"
#endif
#include "dti_conn_mng.h"

#include "phb.h"
#include "psa.h"
#include "cmh.h"
#include "cmh_phb.h"
#include "psa.h"
#include "psa_sim.h"
#include "cus_aci.h"
#include "cmh_mm.h"
#include "cmh_sim.h"

#include "Mfw_band.h"


/*
+--------------------------------------------------------------------+
| PROJECT: GSM-MFW (8417)               MODULE:  MFW_BAND          |
| STATE  : code                         ROUTINE: band_radio_mode_switch|
+--------------------------------------------------------------------+


   PURPOSE :   Set radio band and mode

*/

T_MFW_BAND_RET band_radio_mode_switch(T_MFW_BAND_MODE mode, UBYTE band)
{
	T_ACI_RETURN ret;

	TRACE_FUNCTION("band_radio_mode_switch");
      /*a0393213 compiler warnings removal - explicit typecasting done*/
	ret = sAT_PercentBAND(CMD_SRC_LCL, (T_ACI_BAND_MODE)mode, band); /*radio mode set without errors*/

	TRACE_EVENT_P1("Band: %d", band);
	TRACE_EVENT_P1("Return val: %d", ret);

	switch(ret)
	{
		case (AT_BUSY):
			return MFW_BAND_Busy;
//			break;  // RAVI
		case (AT_FAIL):
			return MFW_BAND_Fail;
//			break;   // RAVI
		case (AT_CMPL):
			return MFW_BAND_OK;
//			break;  // RAVI
		case (AT_EXCT):
			return MFW_BAND_InProgress;
//			break;   // RAVI
		default:
			return MFW_BAND_Fail;
//			break;     // RAVI
	}
}


/*
+--------------------------------------------------------------------+
| PROJECT: GSM-MFW (8417)               MODULE:  MFW_BAND          |
| STATE  : code                         ROUTINE: band_get_radio_modes  |
+--------------------------------------------------------------------+


   PURPOSE :   Get list of possible bands

*/

T_MFW_BAND_RET band_get_radio_modes(T_MFW_BAND_MODE* maxMode, UBYTE *band)
{
	T_ACI_RETURN ret;

	ret = tAT_PercentBAND(CMD_SRC_LCL, (T_ACI_BAND_MODE*)maxMode, (UBYTE*)band);

	if (ret == AT_CMPL)
		return MFW_BAND_OK;
	else
		return MFW_BAND_Fail;
}

/*
+--------------------------------------------------------------------------+
| PROJECT: GSM-MFW (8417)               MODULE:  MFW_BAND                |
| STATE  : code                         ROUTINE: band_get_current_radio_mode  |
+---------------------------------------------------------------------------+


   PURPOSE :   Get current band setting

*/
T_MFW_BAND_RET band_get_current_radio_mode(T_MFW_BAND_MODE* mode, UBYTE* band)
{
	T_ACI_RETURN ret;

	ret = qAT_PercentBAND(CMD_SRC_LCL, (T_ACI_BAND_MODE*)mode, (UBYTE*)band);

	if (ret == AT_CMPL)
		return MFW_BAND_OK;
	else
		return MFW_BAND_Fail;

}