FreeCalypso > hg > fc-tourmaline
view src/ui/mfw/mfw_td.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 92abb46dc1ba |
| children |
line wrap: on
line source
#ifndef _MFW_TD_H_ #define _MFW_TD_H_ /* +--------------------------------------------------------------------+ | PROJECT: MMI-Framework (8417) $Workfile:: mfw_td.c $| | $Author:: NDH $Revision:: 1 $| | CREATED: 03.03.2003 $Modtime:: 10.04.00 14:58 $| | STATE : code $| +--------------------------------------------------------------------+ MODULE : MFW_TD PURPOSE : This modul contains Time and Date functionality. */ #include <string.h> #if defined (NEW_FRAME) #include "typedefs.h" #include "vsi.h" #include "pei.h" #include "custom.h" #include "gsm.h" #else #include "STDDEFS.H" #include "custom.h" #include "gsm.h" #include "vsi.h" #endif #include "mfw_mfw.h" #include "mfw_utils.h" #include "cus_aci.h" #include "prim.h" #include "pcm.h" #include "rtc.h" /***************************Data types**************************************** **/ #define T_MFW_TIME T_RTC_TIME #define T_MFW_DATE T_RTC_DATE typedef enum { MFW_TIME_FORMAT_12HOUR, MFW_TIME_FORMAT_24HOUR } T_MFW_TIME_FORMAT; /*SPR 2639, added data structure definition for writing to FFS*/ typedef struct { T_MFW_TIME alarm_time; T_MFW_DATE alarm_date; } T_MFW_ALARM_INFO; /* * TD Parameter */ #define T_MFW_TD_PARA UBYTE /* * Time and date Control Block */ typedef struct { T_MFW_EVENT emask; /* events of interest */ T_MFW_EVENT event; /* current event */ T_MFW_CB handler; T_MFW_TD_PARA para; } T_MFW_TD; /*************************************Events**********************************************/ #define MFW_TD_ALARM 1 /***************************Prototypes**************************************** **/ void mfw_td_init(void); // Initialise time and date on ME switch-on // RAVI T_MFW_HND mfw_td_create(MfwHnd hWin, MfwEvt event, MfwCb cbfunc);//specify MFW event handler MfwRes mfw_td_delete (MfwHnd h);//delete event handler MfwRes mfw_td_set_time(T_MFW_TIME* time);//set the current time MfwRes mfw_td_set_date(T_MFW_DATE* date);//et the current date char* mfw_td_get_clock_str(void); // return clock string (ASCII).Used by MmiIdle // RAVI char* mfw_td_get_date_str(void); // return date string(ASCII) // RAVI T_MFW_DATE* mfw_td_get_date(void);//return date structure .Used by MmiTimeDate // RAVI T_MFW_TIME* mfw_td_get_time(void);//return time structure // RAVI MfwRes mfw_td_set_alarm(T_MFW_TIME* time, T_MFW_DATE* date);//set alarm MfwRes mfw_td_cancel_alarm(void);//cancel alarm // RAVI MfwRes mfw_td_get_alarm(T_MFW_TIME* time, T_MFW_DATE* date);// MmiTimeDate, editing MfwRes mfw_td_set_time_format(T_MFW_TIME_FORMAT format);//set time format /*SPR 2639, added prototype for this function so it can be called from outside the module */ UBYTE mfw_td_convert_to_24_hour(T_MFW_TIME* time);//returns the hour value in 24-hour clock format void mfw_td_exit(void); //kill any data structures // RAVI /* Added to remove warning Aug - 11 */ #ifdef NEPTUNE_BOARD EXTERN S32 ffs_fread(const S8 *name, void *addr, S32 size); EXTERN S8 ffs_fwrite(const S8 *pathname, void *src, S32 size); #endif //NEPTUNE_BOARD /* End - remove warning Aug - 11 */ #endif //_MFW_TD_H_