FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_gsmcom.val @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 35f7a1dc9f7d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_gsmcom.val | | SOURCE : "sap\gsmcom.pdf" | | LastModified : "2002-10-04" | | IdAndVersion : "8443.100.02.008" | | SrcFileTime : "Thu Nov 29 09:43:26 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_GSMCOM_VAL #define P_GSMCOM_VAL #define CDG_ENTER__P_GSMCOM_VAL #define CDG_ENTER__FILENAME _P_GSMCOM_VAL #define CDG_ENTER__P_GSMCOM_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_GSMCOM_VAL__LAST_MODIFIED _2002_10_04 #define CDG_ENTER__P_GSMCOM_VAL__ID_AND_VERSION _8443_100_02_008 #define CDG_ENTER__P_GSMCOM_VAL__SRC_FILE_TIME _Thu_Nov_29_09_43_26_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_GSMCOM_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_gsmcom_dummy */ /* * user defined constants */ #define SIM_ORIGINATING_ENTITY (0x0) #define ACI_ORIGINATING_ENTITY (0x1) #define RLP_ORIGINATING_ENTITY (0x2) #define RR_ORIGINATING_ENTITY (0x3) #define MM_ORIGINATING_ENTITY (0x4) #define CC_ORIGINATING_ENTITY (0x5) #define SS_ORIGINATING_ENTITY (0x6) #define SMSCP_ORIGINATING_ENTITY (0x7) #define SMSRP_ORIGINATING_ENTITY (0x8) #define SMSTP_ORIGINATING_ENTITY (0x9) #define GMM_ORIGINATING_ENTITY (0xa) #define SM_ORIGINATING_ENTITY (0xb) #define FAD_ORIGINATING_ENTITY (0xc) #define T30_ORIGINATING_ENTITY (0xd) #define GRR_ORIGINATING_ENTITY (0xe) #define PPP_ORIGINATING_ENTITY (0xf) #define LLC_ORIGINATING_ENTITY (0x10) #define SNDCP_ORIGINATING_ENTITY (0x11) #define PKTIO_ORIGINATING_ENTITY (0x12) #define PSI_ORIGINATING_ENTITY (0x13) #include "CDG_LEAVE.h" #endif