view cdg-hybrid/sap/cci.pdf @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents 35f7a1dc9f7d
children
line wrap: on
line source

;********************************************************************************
;*** File           : cci.pdf
;*** Creation       : Wed Mar 11 09:57:44 CST 2009
;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1
;*** Copyright      : (c) Texas Instruments AG, Berlin Germany 2002
;********************************************************************************
;*** Document Type  : Service Access Point Specification
;*** Document Name  : cci
;*** Document No.   : 8441.118.00.017
;*** Document Date  : 2003-01-13
;*** Document Status: BEING_PROCESSED
;*** Document Author: UT
;********************************************************************************



PRAGMA 	SRC_FILE_TIME 	"Thu Nov 29 09:37:42 2007"
PRAGMA 	LAST_MODIFIED 	"2003-01-13"
PRAGMA 	ID_AND_VERSION 	"8441.118.00.017"






VALTAB 	VAL_algo_type
VAL 	0 	CCI_ALGO_V42 	"V42bis algorithm"

VALTAB 	VAL_comp_inst
VAL 	0 	CCI_COMP_INST_V42_0 	"first instance for V42bis"




VAR 	algo_type 	"algorithm type" 	B

VAL 	@p_cci - VAL_algo_type@ 	

VAR 	comp_inst 	"compressor instance" 	B

VAL 	@p_cci - VAL_comp_inst@ 	







; CCI_INIT_REQ 	0x3604



PRIM 	CCI_INIT_REQ 	0x3604
{
 	algo_type 	 ; algorithm type
 	comp_inst 	 ; compressor instance
}