FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/sap/udp.pdf @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | 35f7a1dc9f7d |
children |
line wrap: on
line source
;******************************************************************************** ;*** File : udp.pdf ;*** Creation : Wed Mar 11 09:58:55 CST 2009 ;*** XSLT Processor : Apache Software Foundation / http://xml.apache.org/xalan-j / supports XSLT-Ver: 1 ;*** Copyright : (c) Texas Instruments AG, Berlin Germany 2002 ;******************************************************************************** ;*** Document Type : Service Access Point Specification ;*** Document Name : udp ;*** Document No. : 8444.100.00.006 ;*** Document Date : 2003-08-26 ;*** Document Status: BEING_PROCESSED ;*** Document Author: JK ;******************************************************************************** PRAGMA SRC_FILE_TIME "Thu Nov 29 09:56:22 2007" PRAGMA LAST_MODIFIED "2003-08-26" PRAGMA ID_AND_VERSION "8444.100.00.006" VALTAB VAL_port VAL 0 UDP_AUTOASSIGN_PORT "UDP must assign a free port number" VALTAB VAL_err VAL 0 UDP_BIND_NOERROR "no error" VAL 1 UDP_BIND_PORTINUSE "port already in use" VAL 2 UDP_BIND_UDPDOWN "udp is deactivated" VAR port "destination port" S VAL @p_udp - VAL_port@ VAR err "error code" B VAL @p_udp - VAL_err@ VAR dst_port "destination port" S VAR src_port "source port" S VAR err_msg "error message" B VAR src_addr "source address" L VAR dst_addr "destination address" L ; UDP_BIND_REQ 0x80000046 ; UDP_BIND_CNF 0x80004046 ; UDP_CLOSEPORT_REQ 0x80010046 ; UDP_CLOSEPORT_CNF 0x80014046 ; UDP_ERROR_IND 0x80024046 ; UDP_ERROR_RES 0x80020046 ; UDP_SHUTDOWN_IND 0x80034046 ; UDP_SHUTDOWN_RES 0x80030046 PRIM UDP_BIND_REQ 0x80000046 { port ; port } PRIM UDP_BIND_CNF 0x80004046 { port ; port err ; error code } PRIM UDP_CLOSEPORT_REQ 0x80010046 { port ; port } PRIM UDP_CLOSEPORT_CNF 0x80014046 { } PRIM UDP_ERROR_IND 0x80024046 { dst_port ; Destination port src_port ; source port err_msg ; error message src_addr ; source address dst_addr ; Destination address } PRIM UDP_ERROR_RES 0x80020046 { } PRIM UDP_SHUTDOWN_IND 0x80034046 { } PRIM UDP_SHUTDOWN_RES 0x80030046 { }