FreeCalypso > hg > fc-tourmaline

view doc/C139-notes @ 78:c632896652ba

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents a62e5bf88434
children
line wrap: on
line source

FC Tourmaline firmware differs from Magnetite in two principal ways when it
comes to Mot C139 target support:

* C139 LCD support is implemented in a more forward-looking manner: instead of
  emulating TI's C-Sample at the lowest R2D driver level and therefore being
  forever limited to 84x48 pixel display size, Tourmaline implements a new
  96x64 pixel framebuffer, matching the native LCD size of C1xx phones.  The UI
  configuration is still black&white only though - the Mother of FreeCalypso
  has no current plans to support color UI on smaller LCD sizes than TI's
  original 176x220 pix.

* Our aftermarket FFS configuration has been changed from 64x3 at 0x3C0000 to
  64x7 at 0x300000.  Our earlier 64x3 config was chosen back in 2015, at that
  time we didn't know how much room we would end up needing for the firmware
  image vs. how much FFS content we would eventually have, and this 64x3 config
  is now deemed to be too small, allowing only one 64 KiB sector for FFS
  content.  Our new FC Tourmaline aftermarket FFS config supports up to 320 KiB
  of FFS content, matches what we use on other platforms with 4 MiB flash chips,
  leaves 3 MiB for the firmware image (our current smallbw UI fw is only 2 MiB),
  and still avoids intersection with Motorola's (or rather Compal's) original
  FFS, which is important for avoiding problems in converting C139 phones back
  and forth between Motorola and FreeCalypso firmwares.