FreeCalypso > hg > fc-tourmaline
view doc/Modem-operation @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sun, 25 Oct 2020 23:41:01 +0000 |
parents | a62e5bf88434 |
children |
line wrap: on
line source
FC Tourmaline stdmodem functional configuration is equivalent to Magnetite hybrid. The only intentional diff from Magnetite to Tourmaline in the modem configuration is the change of Nucleus: Magnetite uses the blob version of Nucleus which came with TCS211-20070608, whereas Tourmaline uses the source version of Nucleus by Comrade XVilka. It is essentially a change from an unknown version of Nucleus to a known one, thus it should generally be considered an improvement - but as always with such changes, extensive verification and testing needs to be done in order to ensure that nothing got broken. Aside from the one intentional change of Nucleus version, FC Tourmaline is an entirely new firmware source tree, thus it is always possible that something could have got broken unintentionally, particularly in rarely-tested areas of the firmware. Therefore, extensive testing will need to be done before we can declare Tourmaline stdmodem as officially replacing Magnetite hybrid for stable modem products.