FreeCalypso > hg > fc-tourmaline
view src/cs/services/lls/lls_api.c @ 78:c632896652ba
mfw/ti1_key.c: properly initialize notified_keys array
The code in this ti1_key.c layer needs to call kpd_subscribe() and
kpd_define_key_notification() functions in order to register with the
KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in
nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all
platforms of interest to us - but it only filled the first 23 slots
in the notified_keys array, resulting in stack garbage being passed
to KPD API functions. The fix consists of initializing the last
missed array slot to KPD_KEY_RECORD, the key ID for the right side
button on the D-Sample handset.
On our current hw targets this "Record" button exists as the EXTRA
button on our Luna keypad board and as the camera button on the
Pirelli DP-L10. There is no support whatsoever for this button
in current BMI+MFW, we have no plans of doing anything with Pirelli's
camera button even if we do get our UI fw running on that phone,
and the Mother's dream of building our own FreeCalypso handset with
the same button arrangement as D-Sample (including the right side
button) is currently very nebulous - but let us nonetheless handle
the full set of buttons on the KPD to MFW interface, and let upper
layers weed out unsupported buttons.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 25 Oct 2020 23:41:01 +0000 |
| parents | 04aaa5622fa7 |
| children |
line wrap: on
line source
/** * @file lls_api.c * * Implementation of Functions. * * @author Laurent Sollier (l-sollier@ti.com) * @version 0.1 */ /* * History: * * Date Author Modification * ---------------------------------------- * 03/12/2002 L Sollier Create * * * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved */ #ifndef _WINDOWS #include "l1sw.cfg" #include "chipset.cfg" #endif #include "lls/lls_api.h" #include "lls/lls_env.h" #include "lls/lls_i.h" /** External declaration */ extern T_LLS_ENV_CTRL_BLK* lls_env_ctrl_blk; /* FreeCalypso addition for L1 sleep manager */ unsigned char iota_ledb_status; /** * @name Functions implementation * */ /*@{*/ /** * function: lls_switch_on */ T_RV_RET lls_switch_on(T_LLS_EQUIPMENT equipment_sort) { #if (ANLG_FAM == 2) T_RV_RET ret = RV_OK; UINT8 equipment_index; /* Check if initialization has been correctly done */ if ( (lls_env_ctrl_blk == 0) || (lls_env_ctrl_blk->swe_is_initialized == FALSE) ) { LLS_SEND_TRACE("LLS: Initialization is not yet done or failed", RV_TRACE_LEVEL_ERROR); return RV_INTERNAL_ERR; } LLS_SEND_TRACE_PARAM("LLS: Switch ON request for equipment", equipment_sort, RV_TRACE_LEVEL_DEBUG_HIGH); /* Retrieve index of the equipment in the table */ ret = lls_search_index(equipment_sort, &equipment_index); if (ret != RV_OK) { LLS_SEND_TRACE("LLS: Equipment is unknown", RV_TRACE_LEVEL_ERROR); return ret; } /* FreeCalypso addition */ if (equipment_sort == LLS_BACKLIGHT) iota_ledb_status = 1; ret = lls_manage_equipment(equipment_index, SWITCH_ON); return ret; #else return RV_NOT_SUPPORTED; #endif } /** * function: lls_switch_off * */ T_RV_RET lls_switch_off(T_LLS_EQUIPMENT equipment_sort) { #if (ANLG_FAM == 2) T_RV_RET ret = RV_OK; UINT8 equipment_index; /* Check if initialization has been correctly done */ if ( (lls_env_ctrl_blk == 0) || (lls_env_ctrl_blk->swe_is_initialized == FALSE) ) { LLS_SEND_TRACE("LLS: Initialization is not yet done or failed", RV_TRACE_LEVEL_ERROR); return RV_INTERNAL_ERR; } LLS_SEND_TRACE_PARAM("LLS: Switch OFF request for equipment", equipment_sort, RV_TRACE_LEVEL_DEBUG_HIGH); /* Retrieve index of the equipment in the table */ ret = lls_search_index(equipment_sort, &equipment_index); if (ret != RV_OK) { LLS_SEND_TRACE("LLS: Equipment is unknown", RV_TRACE_LEVEL_ERROR); return ret; } ret = lls_manage_equipment(equipment_index, SWITCH_OFF); /* FreeCalypso addition */ if (equipment_sort == LLS_BACKLIGHT) iota_ledb_status = 0; return ret; #else return RV_NOT_SUPPORTED; #endif } /*@}*/