view src/g23m-aci/aci/aci_lst.h @ 78:c632896652ba

mfw/ti1_key.c: properly initialize notified_keys array The code in this ti1_key.c layer needs to call kpd_subscribe() and kpd_define_key_notification() functions in order to register with the KPD driver. The original code passed KPD_NB_PHYSICAL_KEYS in nb_notified_keys - this constant is defined to 24 in kpd_cfg.h on all platforms of interest to us - but it only filled the first 23 slots in the notified_keys array, resulting in stack garbage being passed to KPD API functions. The fix consists of initializing the last missed array slot to KPD_KEY_RECORD, the key ID for the right side button on the D-Sample handset. On our current hw targets this "Record" button exists as the EXTRA button on our Luna keypad board and as the camera button on the Pirelli DP-L10. There is no support whatsoever for this button in current BMI+MFW, we have no plans of doing anything with Pirelli's camera button even if we do get our UI fw running on that phone, and the Mother's dream of building our own FreeCalypso handset with the same button arrangement as D-Sample (including the right side button) is currently very nebulous - but let us nonetheless handle the full set of buttons on the KPD to MFW interface, and let upper layers weed out unsupported buttons.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 25 Oct 2020 23:41:01 +0000
parents fa8dc04885d8
children
line wrap: on
line source

/* 
+----------------------------------------------------------------------------- 
|  Project :  GSM-PS (6147)
|  Modul   :  aci_lst
+----------------------------------------------------------------------------- 
|  Copyright 2002 Texas Instruments Berlin, AG 
|                 All rights reserved. 
| 
|                 This file is confidential and a trade secret of Texas 
|                 Instruments Berlin, AG 
|                 The receipt of or possession of this file does not convey 
|                 any rights to reproduce or disclose its contents or to 
|                 manufacture, use, or sell anything it may describe, in 
|                 whole, or in part, without the specific written consent of 
|                 Texas Instruments Berlin, AG. 
+----------------------------------------------------------------------------- 
|  Purpose :  Process lists in ACI
+----------------------------------------------------------------------------- 
*/ 

#ifndef ACI_LST_H
#define ACI_LST_H


/*==== TYPES ======================================================*/

typedef struct ACI_LIST_S
{
  void               *msg;
  struct ACI_LIST_S  *next;
} T_ACI_LIST;

typedef BOOL  T_LIST_FIND_FCT (UBYTE criterium, void *elem);
typedef BOOL  T_LIST_FIND_FCT_PSI (U32 criterium, void *elem);

/*==== PROTOTYPES =================================================*/

/*==== EXPORT =====================================================*/

EXTERN USHORT get_list_count      (T_ACI_LIST *list);
EXTERN T_ACI_LIST *new_list       (void);
EXTERN BOOL insert_list           (T_ACI_LIST       *list, 
                                   void             *buffer);
EXTERN BOOL insert_shift_list (T_ACI_LIST *list, void *buffer);

EXTERN void *get_next_element     (T_ACI_LIST       *search_list, 
                                   void             *prev_elem);

EXTERN void *find_next_element    (T_ACI_LIST       *search_list, 
                                   void             *prev_elem,
                                   UBYTE            criterium, 
                                   T_LIST_FIND_FCT  test_criterium);

EXTERN void *find_element         (T_ACI_LIST       *search_list, 
                                   UBYTE            criterium, 
                                   T_LIST_FIND_FCT  test_criterium);


EXTERN void *remove_first_element (T_ACI_LIST       *search_list);
EXTERN void *remove_element       (T_ACI_LIST       *search_list, 
                                   UBYTE            criterium, 
                                   T_LIST_FIND_FCT  test_criterium);
#ifdef FF_PSI
EXTERN void *psi_find_next_element    (T_ACI_LIST       *search_list, 
                                   void             *prev_elem,
                                   U32           criterium, 
                                   T_LIST_FIND_FCT_PSI  test_criterium);
EXTERN void *psi_find_element (T_ACI_LIST *search_list,
                           U32 criterium,
                           T_LIST_FIND_FCT_PSI test_criterium);
EXTERN void *psi_remove_element       (T_ACI_LIST       *search_list, 
                                   U32            criterium, 
                                   T_LIST_FIND_FCT_PSI test_criterium);
#endif /*FF_PSI*/

#endif